You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/06/14 12:15:47 UTC
[GitHub] [flink] aljoscha commented on a change in pull request #8642:
[FLINK-1722][datastream] Enable the InitializeOnMaster and FinalizeOnMaster
interfaces on datastream
aljoscha commented on a change in pull request #8642: [FLINK-1722][datastream] Enable the InitializeOnMaster and FinalizeOnMaster interfaces on datastream
URL: https://github.com/apache/flink/pull/8642#discussion_r293771876
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/SimpleOperatorFactory.java
##########
@@ -47,6 +48,10 @@
} else if (operator instanceof StreamSource &&
((StreamSource) operator).getUserFunction() instanceof InputFormatSourceFunction) {
return new SimpleInputFormatOperatorFactory<OUT>((StreamSource) operator);
+ } else if (operator instanceof StreamSink &&
+ ((StreamSink) operator).getUserFunction() instanceof OutputFormatSinkFunction) {
+ //noinspection unchecked
Review comment:
I think `noinspection` is only for IntelliJ, for properly suppressing warnings here we have to use `@SuppressWarnings("unchecked")`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services