[GitHub] [incubator-kyuubi] timothy65535 commented on a change in pull request #986: [KYUUBI #962] Support engine pool feature

[GitBox <gi...@apache.org>]

timothy65535 commented on a change in pull request #986:
URL: https://github.com/apache/incubator-kyuubi/pull/986#discussion_r695599732



##########
File path: kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala
##########
@@ -606,6 +606,36 @@ object KyuubiConf {
     .version("1.2.0")
     .fallbackConf(LEGACY_ENGINE_SHARE_LEVEL)
 
+  val ENGINE_PROVIDE_POLICY: ConfigEntry[String] = buildConf("engine.provide.policy")
+    .doc("Multiple engines can be exposed under same space when using engine pool, " +
+      "choose the appropriate strategy according to different scenarios.")
+    .version("1.4.0")
+    .stringConf
+    .transform(_.toUpperCase(Locale.ROOT))
+    .createWithDefault(ProvidePolicy.RANDOM.toString)
+
+  val ENGINE_POOL_ENABLED: ConfigEntry[Boolean] = buildConf("engine.pool.enabled")
+    .doc("When true, kyuubi will provides engine pool feature.")
+    .version("1.4.0")
+    .booleanConf
+    .createWithDefault(false)
+
+  val ENGINE_POOL_SIZE_THRESHOLD: ConfigEntry[Int] = buildConf("engine.pool.size.threshold")
+    .doc("This parameter is introduced as a server-side parameter, " +
+      "and controls the upper limit of the engine pool.")
+    .version("1.4.0")
+    .intConf
+    .checkValue(s => s > 0 && s <= 32, "Invalid Engine Pool Threshold Size, " +
+      "should be between 0 and 33.")
+    .createWithDefault(16)
+
+  val ENGINE_POOL_SIZE: ConfigEntry[Int] = buildConf("engine.pool.size")
+    .doc("Max number of engines that can be provided to clients.")
+    .version("1.4.0")
+    .intConf
+    .checkValue(s => s > 0, "Invalid Engine Pool Size, must be positive number.")
+    .createWithDefault(1)

Review comment:
       I think the option `kyuubi.engine.pool.size.threshold` cat give users the opportunity to set the threshold.
   
   if we use `checkValue`, the `50` is hardcode.
   `.checkValue(s => s > 0 && s < 50, "Invalid Engine Pool Size, should be between 0 and 50")`
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org