You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "lgbo-ustc (via GitHub)" <gi...@apache.org> on 2025/05/08 02:53:18 UTC

[PR] [GLUTEN-9448][Flink] Hot fix UT package path [incubator-gluten]

lgbo-ustc opened a new pull request, #9552:
URL: https://github.com/apache/incubator-gluten/pull/9552

   ## What changes were proposed in this pull request?
   
   (Please fill in changes proposed in this fix)
   
   Fixes: #9448
   
   ## How was this patch tested?
   
   (Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
   
   
   (If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org

Re: [PR] [GLUTEN-9448][Flink] Hot fix UT package path [incubator-gluten]

Posted by "PHILO-HE (via GitHub)" <gi...@apache.org>.
PHILO-HE commented on PR #9552:
URL: https://github.com/apache/incubator-gluten/pull/9552#issuecomment-2861678595

   > Include this part of the testing into CI is highly desirable.
   
   @lgbo-ustc, if these tests can pass in your internal verification. I will create a separate pr to add a new CI job soon.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org

Re: [PR] [GLUTEN-9448][Flink] Hot fix UT package path [incubator-gluten]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9552:
URL: https://github.com/apache/incubator-gluten/pull/9552#issuecomment-2861448309

   https://github.com/apache/incubator-gluten/issues/9448


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org

Re: [PR] [GLUTEN-9448][Flink] Hot fix UT package path [incubator-gluten]

Posted by "shuai-xu (via GitHub)" <gi...@apache.org>.
shuai-xu commented on PR #9552:
URL: https://github.com/apache/incubator-gluten/pull/9552#issuecomment-2864909031

   It seems mvn -DskipTest doesn't work


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org

Re: [PR] [GLUTEN-9448][Flink] Hot fix UT package path [incubator-gluten]

Posted by "lgbo-ustc (via GitHub)" <gi...@apache.org>.
lgbo-ustc commented on PR #9552:
URL: https://github.com/apache/incubator-gluten/pull/9552#issuecomment-2861449314

   @shuai-xu @PHILO-HE 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org

Re: [PR] [GLUTEN-9448][Flink] Hot fix UT package path [incubator-gluten]

Posted by "lgbo-ustc (via GitHub)" <gi...@apache.org>.
lgbo-ustc commented on PR #9552:
URL: https://github.com/apache/incubator-gluten/pull/9552#issuecomment-2861613391

   > @lgbo-ustc, thank you so much for your quick fix! cc @shuai-xu
   > 
   > BTW, will these tests be included in Gluten CI at some proper time point?
   
   Include this part of the testing into CI is highly desirable.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org

Re: [PR] [GLUTEN-9448][Flink] Hot fix UT package path [incubator-gluten]

Posted by "lgbo-ustc (via GitHub)" <gi...@apache.org>.
lgbo-ustc commented on PR #9552:
URL: https://github.com/apache/incubator-gluten/pull/9552#issuecomment-2861685183

   > > Include this part of the testing into CI is highly desirable.
   > 
   > @lgbo-ustc, if these tests can pass in your internal verification. I will create a separate pr to add a new CI job soon.
   
   The dependency of `velox4j` should be resolved at first. Currently gluten flink relys on a local compiled `velox4j`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org

Re: [PR] [GLUTEN-9448][Flink] Hot fix UT package path [incubator-gluten]

Posted by "lgbo-ustc (via GitHub)" <gi...@apache.org>.
lgbo-ustc merged PR #9552:
URL: https://github.com/apache/incubator-gluten/pull/9552


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org

Re: [PR] [GLUTEN-9448][Flink] Hot fix UT package path [incubator-gluten]

Posted by "zhanglistar (via GitHub)" <gi...@apache.org>.
zhanglistar commented on PR #9552:
URL: https://github.com/apache/incubator-gluten/pull/9552#issuecomment-2861478490

   @PHILO-HE Please review this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org

Re: [PR] [GLUTEN-9448][Flink] Hot fix UT package path [incubator-gluten]

Posted by "PHILO-HE (via GitHub)" <gi...@apache.org>.
PHILO-HE commented on PR #9552:
URL: https://github.com/apache/incubator-gluten/pull/9552#issuecomment-2871926456

   @lgbo-ustc, gentle reminder. Please remember to revise commit message to basically align with PR title when merging PR. See the example below. Thank you!
   
   
   
   ![Screen Shot 2025-05-12 at 18 14 39](https://github.com/user-attachments/assets/2261a089-a196-4f67-8213-275910062402)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org

Re: [PR] [GLUTEN-9448][Flink] Hot fix UT package path [incubator-gluten]

Posted by "lgbo-ustc (via GitHub)" <gi...@apache.org>.
lgbo-ustc commented on PR #9552:
URL: https://github.com/apache/incubator-gluten/pull/9552#issuecomment-2864919358

   -Dmaven.test.skip=true


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org