You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/10/26 11:45:36 UTC
[GitHub] [camel-karavan] apupier opened a new issue #46: Durations doesn't support notation with letters
apupier opened a new issue #46:
URL: https://github.com/apache/camel-karavan/issues/46
For instance for period of timer, we cannot write `1d`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-karavan] mgubaidullin commented on issue #46: Durations doesn't support notation with letters
Posted by GitBox <gi...@apache.org>.
mgubaidullin commented on issue #46:
URL: https://github.com/apache/camel-karavan/issues/46#issuecomment-952937091
@apupier Is it Kamelet or Component? Could you please provide an example?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-karavan] davsclaus commented on issue #46: Durations doesn't support notation with letters
Posted by GitBox <gi...@apache.org>.
davsclaus commented on issue #46:
URL: https://github.com/apache/camel-karavan/issues/46#issuecomment-954750085
Its the options that have type=duration in the json for the component
Such as timer: https://github.com/apache/camel/blob/main/components/camel-timer/src/generated/resources/org/apache/camel/component/timer/timer.json
```
"period": { "kind": "parameter", "displayName": "Period", "group": "consumer", "label": "", "required": false, "type": "duration", "javaType": "long", "deprecated": false, "autowired": false, "secret": false, "defaultValue": "1000", "description": "If greater than 0, generate periodic events every period." },
```
A kamelet is much less likely to use such types as the options they expose are manually defined in their yaml file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-karavan] mgubaidullin commented on issue #46: Durations doesn't support notation with letters
Posted by GitBox <gi...@apache.org>.
mgubaidullin commented on issue #46:
URL: https://github.com/apache/camel-karavan/issues/46#issuecomment-954758722
Current implementation for Components generates text field for duration parameters
<img width="749" alt="timer" src="https://user-images.githubusercontent.com/1379213/139446200-0c139dc2-0866-4a8e-8fe6-e6de29be4ca5.png">
As a result it creates the following yaml:
```
flows:
- from:
uri: timer
parameters:
period: 10s
```
Is it correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-karavan] mgubaidullin edited a comment on issue #46: Durations doesn't support notation with letters
Posted by GitBox <gi...@apache.org>.
mgubaidullin edited a comment on issue #46:
URL: https://github.com/apache/camel-karavan/issues/46#issuecomment-954764826
@davsclaus It is quite confusing that Timer Component and Timer Kamelet have different types for `period` parameter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-karavan] mgubaidullin closed issue #46: Durations doesn't support notation with letters
Posted by GitBox <gi...@apache.org>.
mgubaidullin closed issue #46:
URL: https://github.com/apache/camel-karavan/issues/46
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-karavan] mgubaidullin closed issue #46: Durations doesn't support notation with letters
Posted by GitBox <gi...@apache.org>.
mgubaidullin closed issue #46:
URL: https://github.com/apache/camel-karavan/issues/46
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-karavan] mgubaidullin closed issue #46: Durations doesn't support notation with letters
Posted by GitBox <gi...@apache.org>.
mgubaidullin closed issue #46:
URL: https://github.com/apache/camel-karavan/issues/46
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-karavan] mgubaidullin commented on issue #46: Durations doesn't support notation with letters
Posted by GitBox <gi...@apache.org>.
mgubaidullin commented on issue #46:
URL: https://github.com/apache/camel-karavan/issues/46#issuecomment-954761454
However for Timer Source Kamelet it generates Numeric Field:
<img width="746" alt="timer-kamelet" src="https://user-images.githubusercontent.com/1379213/139446674-c93d976f-1946-4ca7-bf42-f2e3082c901d.png">
with the following output:
```
flows:
- from:
uri: 'kamelet:timer-source'
parameters:
period: 1000
```
because period is defined as `type: integer` in kamelet https://github.com/apache/camel-kamelets/blob/8b91738711fd522541b12fdda2564c6942df30ff/timer-source.kamelet.yaml#L42
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-karavan] davsclaus commented on issue #46: Durations doesn't support notation with letters
Posted by GitBox <gi...@apache.org>.
davsclaus commented on issue #46:
URL: https://github.com/apache/camel-karavan/issues/46#issuecomment-954762909
Yes this is correct what Karavan does
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-karavan] mgubaidullin commented on issue #46: Durations doesn't support notation with letters
Posted by GitBox <gi...@apache.org>.
mgubaidullin commented on issue #46:
URL: https://github.com/apache/camel-karavan/issues/46#issuecomment-954764826
It is quite confusing that Timer Component and Timer Kamelet have different types for `period` parameter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org