[GitHub] [hudi] prashantwason commented on a diff in pull request #8496: [HUDI-6101] Use UnBoundedCompactionStrategy for MDT compactions.

["prashantwason (via GitHub)" <gi...@apache.org>]

prashantwason commented on code in PR #8496:
URL: https://github.com/apache/hudi/pull/8496#discussion_r1172185710


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -292,6 +292,10 @@ private HoodieWriteConfig createMetadataWriteConfig(
             .withInlineCompaction(false)
             .withMaxNumDeltaCommitsBeforeCompaction(writeConfig.getMetadataCompactDeltaCommitMax())
             .withEnableOptimizedLogBlocksScan(String.valueOf(writeConfig.enableOptimizedLogBlocksScan()))
+            // Compaction on metadata table is used as a barrier for archiving on main dataset and for validating the
+            // deltacommits having corresponding completed commits. Therefore, we need to compact all fileslices of all
+            // partitions together requiring UnBoundedCompactionStrategy.
+            .withCompactionStrategy(new UnBoundedCompactionStrategy())

Review Comment:
   500GB may be enough for most indexes we have today. But record index is usually in TBs and hence this issue was seen there. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org