You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-dev@xmlgraphics.apache.org by sd...@iptech-group.com on 2015/11/20 15:16:10 UTC

[AFP Renderer] Increased document size

Hello,

 

I'm using FOP Trunk in production and I noticed that the size of AFP
documents has substantially increased compared to FOP 1.1. After some
debugging, I found out that the issue is located in method equals inside
AFPResourceInfo.java; the current code does not handle the case in which the
two fields to be compared have null values. As far as I know, two Java
instances of the same type are considered equal if they both have null
values.

 

Attached to this email, you find all the files you need to reproduce the
afore mentioned issue.

 

Thanks,

 

Seifeddine DRIDI

Re: [AFP Renderer] Increased document size

Posted by Chris Bowditch <bo...@hotmail.com>.
Thank you

On 25/11/2015 16:59, sdridi@iptech-group.com wrote:
> Hi,
>
> I already did that a long time ago
> https://issues.apache.org/jira/browse/FOP-2455
>
> -----Message d'origine-----
> De : Chris Bowditch [mailto:bowditch_chris@hotmail.com]
> Envoyé : mercredi 25 novembre 2015 17:34
> À : fop-dev@xmlgraphics.apache.org
> Objet : Re: [AFP Renderer] Increased document size
>
> Hi Seifeddine,
>
> Can you log a bug in JIRA please so this issue is not forgotten?
>
> Thanks,
>
> Chris
>
> On 20/11/2015 14:16, sdridi@iptech-group.com wrote:
>> Hello,
>>
>> I’m using FOP Trunk in production and I noticed that the size of AFP
>> documents has substantially increased compared to FOP 1.1. After some
>> debugging, I found out that the issue is located in method equals
>> inside AFPResourceInfo.java; the current code does not handle the case
>> in which the two fields to be compared have null values. As far as I
>> know, two Java instances of the same type are considered equal if they
>> both have null values.
>>
>> Attached to this email, you find all the files you need to reproduce
>> the afore mentioned issue.
>>
>> Thanks,
>>
>> Seifeddine DRIDI
>>
>
>
>

RE: [AFP Renderer] Increased document size

Posted by sd...@iptech-group.com.
Hi,

I already did that a long time ago
https://issues.apache.org/jira/browse/FOP-2455

-----Message d'origine-----
De : Chris Bowditch [mailto:bowditch_chris@hotmail.com] 
Envoyé : mercredi 25 novembre 2015 17:34
À : fop-dev@xmlgraphics.apache.org
Objet : Re: [AFP Renderer] Increased document size

Hi Seifeddine,

Can you log a bug in JIRA please so this issue is not forgotten?

Thanks,

Chris

On 20/11/2015 14:16, sdridi@iptech-group.com wrote:
>
> Hello,
>
> I’m using FOP Trunk in production and I noticed that the size of AFP 
> documents has substantially increased compared to FOP 1.1. After some 
> debugging, I found out that the issue is located in method equals 
> inside AFPResourceInfo.java; the current code does not handle the case 
> in which the two fields to be compared have null values. As far as I 
> know, two Java instances of the same type are considered equal if they 
> both have null values.
>
> Attached to this email, you find all the files you need to reproduce 
> the afore mentioned issue.
>
> Thanks,
>
> Seifeddine DRIDI
>

Re: [AFP Renderer] Increased document size

Posted by Chris Bowditch <bo...@hotmail.com>.
Hi Seifeddine,

Can you log a bug in JIRA please so this issue is not forgotten?

Thanks,

Chris

On 20/11/2015 14:16, sdridi@iptech-group.com wrote:
>
> Hello,
>
> I’m using FOP Trunk in production and I noticed that the size of AFP 
> documents has substantially increased compared to FOP 1.1. After some 
> debugging, I found out that the issue is located in method equals 
> inside AFPResourceInfo.java; the current code does not handle the case 
> in which the two fields to be compared have null values. As far as I 
> know, two Java instances of the same type are considered equal if they 
> both have null values.
>
> Attached to this email, you find all the files you need to reproduce 
> the afore mentioned issue.
>
> Thanks,
>
> Seifeddine DRIDI
>