[GitHub] [iceberg] openinx commented on a change in pull request #2321: Spark: fix invalid unit test

[GitBox <gi...@apache.org>]

openinx commented on a change in pull request #2321:
URL: https://github.com/apache/iceberg/pull/2321#discussion_r592198495



##########
File path: spark/src/test/java/org/apache/iceberg/spark/source/TestSparkReaderDeletes.java
##########
@@ -129,6 +129,18 @@ public StructLikeSet rowSet(String name, Table table, String... columns) {
   public void testEqualityDeleteWithFilter() throws IOException {
     String tableName = "test_with_filter";
     Table table = createTable(tableName, SCHEMA, SPEC);
+

Review comment:
       Why not just use the created `test` table ( in `writeTestDataFile` annotated with a `Before` )  ? then we don't have to write those rows again for this newly created `test_with_filter` table.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org