You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "featzhang (via GitHub)" <gi...@apache.org> on 2023/03/25 02:17:50 UTC
[GitHub] [inlong] featzhang opened a new pull request, #7691: [INLONG-7690][Manager] Creating schema of StreamSource by CSV
featzhang opened a new pull request, #7691:
URL: https://github.com/apache/inlong/pull/7691
### Prepare a Pull Request
*[INLONG-7690][Manager] Creating schema of StreamSource by CSV*
- Fixes #7690
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] featzhang closed pull request #7691: [INLONG-7690][Manager] Creating schema of StreamSource by CSV
Posted by "featzhang (via GitHub)" <gi...@apache.org>.
featzhang closed pull request #7691: [INLONG-7690][Manager] Creating schema of StreamSource by CSV
URL: https://github.com/apache/inlong/pull/7691
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] featzhang closed pull request #7691: [INLONG-7690][Manager] Creating schema of StreamSource by CSV
Posted by "featzhang (via GitHub)" <gi...@apache.org>.
featzhang closed pull request #7691: [INLONG-7690][Manager] Creating schema of StreamSource by CSV
URL: https://github.com/apache/inlong/pull/7691
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #7691: [INLONG-7690][Manager] Creating schema of StreamSource by CSV
Posted by "healchow (via GitHub)" <gi...@apache.org>.
healchow commented on code in PR #7691:
URL: https://github.com/apache/inlong/pull/7691#discussion_r1148581143
##########
inlong-manager/manager-web/src/main/java/org/apache/inlong/manager/web/controller/StreamSinkController.java:
##########
@@ -118,11 +118,14 @@ public Response<Boolean> deleteByKey(@RequestParam(required = false, defaultValu
return Response.success(sinkService.deleteByKey(groupId, streamId, name, startProcess, username));
}
- @RequestMapping(value = "/sink/parseFields", method = RequestMethod.POST)
- @ApiOperation(value = "parse stream sink fields from JSON string")
- @ApiImplicitParam(name = "fieldsJson", dataTypeClass = String.class, required = true)
- public Response<List<SinkField>> parseFields(@RequestBody String fieldsJson) {
- return Response.success(sinkService.parseFields(fieldsJson));
+ @RequestMapping(value = "/sink/parseFields/{statementType}", method = RequestMethod.POST)
Review Comment:
Can we encapsulate all the parameters into an object without displaying the parameters in the path?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] fuweng11 commented on pull request #7691: [INLONG-7690][Manager] Creating schema of StreamSource by CSV
Posted by "fuweng11 (via GitHub)" <gi...@apache.org>.
fuweng11 commented on PR #7691:
URL: https://github.com/apache/inlong/pull/7691#issuecomment-1484375436
@featzhang At the same time, please modify `StreamSinkApi parseFields` and `InlongStreamApi.parseFields`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org