You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@servicemix.apache.org by "Gianfranco Boccalon (JIRA)" <ji...@apache.org> on 2008/02/27 10:16:17 UTC

[jira] Created: (SM-1252) CXF BC provider doesn't detect automatically the SOAP version of the message to send

CXF BC provider doesn't detect automatically the SOAP version of the message to send
------------------------------------------------------------------------------------

                 Key: SM-1252
                 URL: https://issues.apache.org/activemq/browse/SM-1252
             Project: ServiceMix
          Issue Type: Bug
          Components: servicemix-cxf-bc
    Affects Versions: 3.2.1
            Reporter: Gianfranco Boccalon


The SOAP version of the message sent is always 1.1 because there is no code that changes it.
I made a patch to the CxfBcProvider class to detect the soap version.
I dont know if this should be done in an interceptor, i made directly in the CxfBcProvider after retrieving the BindingOperationInfo.


        // Retrieve the BindingOperationInfo
        BindingOperationInfo boi = ......;

        // SOAP 1.2 support
        String bindingId = boi.getBinding().getBindingId();
        if (WSDLConstants.SOAP11_NAMESPACE.equals(bindingId)) {
            message.setVersion(Soap11.getInstance());
        } else if (WSDLConstants.SOAP12_NAMESPACE.equals(bindingId)) {
            message.setVersion(Soap12.getInstance());
        }
	    ///////////



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (SM-1252) CXF BC provider doesn't detect automatically the SOAP version of the message to send

Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/SM-1252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Freeman Fang resolved SM-1252.
------------------------------

    Fix Version/s: 3.2.2
                   3.3
       Resolution: Fixed

> CXF BC provider doesn't detect automatically the SOAP version of the message to send
> ------------------------------------------------------------------------------------
>
>                 Key: SM-1252
>                 URL: https://issues.apache.org/activemq/browse/SM-1252
>             Project: ServiceMix
>          Issue Type: Bug
>          Components: servicemix-cxf-bc
>    Affects Versions: 3.2.1
>            Reporter: Gianfranco Boccalon
>            Assignee: Freeman Fang
>             Fix For: 3.2.2, 3.3
>
>
> The SOAP version of the message sent is always 1.1 because there is no code that changes it.
> I made a patch to the CxfBcProvider class to detect the soap version.
> I dont know if this should be done in an interceptor, i made directly in the CxfBcProvider after retrieving the BindingOperationInfo.
>         // Retrieve the BindingOperationInfo
>         BindingOperationInfo boi = ......;
>         // SOAP 1.2 support
>         String bindingId = boi.getBinding().getBindingId();
>         if (WSDLConstants.SOAP11_NAMESPACE.equals(bindingId)) {
>             message.setVersion(Soap11.getInstance());
>         } else if (WSDLConstants.SOAP12_NAMESPACE.equals(bindingId)) {
>             message.setVersion(Soap12.getInstance());
>         }
> 	    ///////////

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SM-1252) CXF BC provider doesn't detect automatically the SOAP version of the message to send

Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/SM-1252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Guillaume Nodet updated SM-1252:
--------------------------------

    Fix Version/s: servicemix-cxf-bc-2008.01

> CXF BC provider doesn't detect automatically the SOAP version of the message to send
> ------------------------------------------------------------------------------------
>
>                 Key: SM-1252
>                 URL: https://issues.apache.org/activemq/browse/SM-1252
>             Project: ServiceMix
>          Issue Type: Bug
>          Components: servicemix-cxf-bc
>    Affects Versions: 3.2.1
>            Reporter: Gianfranco Boccalon
>            Assignee: Freeman Fang
>             Fix For: 3.2.2, 3.3, servicemix-cxf-bc-2008.01
>
>
> The SOAP version of the message sent is always 1.1 because there is no code that changes it.
> I made a patch to the CxfBcProvider class to detect the soap version.
> I dont know if this should be done in an interceptor, i made directly in the CxfBcProvider after retrieving the BindingOperationInfo.
>         // Retrieve the BindingOperationInfo
>         BindingOperationInfo boi = ......;
>         // SOAP 1.2 support
>         String bindingId = boi.getBinding().getBindingId();
>         if (WSDLConstants.SOAP11_NAMESPACE.equals(bindingId)) {
>             message.setVersion(Soap11.getInstance());
>         } else if (WSDLConstants.SOAP12_NAMESPACE.equals(bindingId)) {
>             message.setVersion(Soap12.getInstance());
>         }
> 	    ///////////

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (SM-1252) CXF BC provider doesn't detect automatically the SOAP version of the message to send

Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/SM-1252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Freeman Fang reassigned SM-1252:
--------------------------------

    Assignee: Freeman Fang

> CXF BC provider doesn't detect automatically the SOAP version of the message to send
> ------------------------------------------------------------------------------------
>
>                 Key: SM-1252
>                 URL: https://issues.apache.org/activemq/browse/SM-1252
>             Project: ServiceMix
>          Issue Type: Bug
>          Components: servicemix-cxf-bc
>    Affects Versions: 3.2.1
>            Reporter: Gianfranco Boccalon
>            Assignee: Freeman Fang
>
> The SOAP version of the message sent is always 1.1 because there is no code that changes it.
> I made a patch to the CxfBcProvider class to detect the soap version.
> I dont know if this should be done in an interceptor, i made directly in the CxfBcProvider after retrieving the BindingOperationInfo.
>         // Retrieve the BindingOperationInfo
>         BindingOperationInfo boi = ......;
>         // SOAP 1.2 support
>         String bindingId = boi.getBinding().getBindingId();
>         if (WSDLConstants.SOAP11_NAMESPACE.equals(bindingId)) {
>             message.setVersion(Soap11.getInstance());
>         } else if (WSDLConstants.SOAP12_NAMESPACE.equals(bindingId)) {
>             message.setVersion(Soap12.getInstance());
>         }
> 	    ///////////

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SM-1252) CXF BC provider doesn't detect automatically the SOAP version of the message to send

Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/SM-1252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=41458#action_41458 ] 

Freeman Fang commented on SM-1252:
----------------------------------

commit fix
http://svn.apache.org/viewvc?rev=631845&view=rev for 3.3 branch
http://svn.apache.org/viewvc?rev=631846&view=rev for 3.2.2 branch


Hi Gianfranco Boccalon,

Your suggestion works, but  we should avoid setting soap version explicitly
Since the soap version info already in the binding info when create service model from the wsdl, so we should use
Message message = ep.getBinding().createMessage();// which will create soap12 message
instead of create create soapmessage explicitly
SoapMessage message = new SoapMessage(new MessageImpl());

Thanks for pointing out this issue
Best Regards
Freeman


> CXF BC provider doesn't detect automatically the SOAP version of the message to send
> ------------------------------------------------------------------------------------
>
>                 Key: SM-1252
>                 URL: https://issues.apache.org/activemq/browse/SM-1252
>             Project: ServiceMix
>          Issue Type: Bug
>          Components: servicemix-cxf-bc
>    Affects Versions: 3.2.1
>            Reporter: Gianfranco Boccalon
>            Assignee: Freeman Fang
>             Fix For: 3.2.2, 3.3
>
>
> The SOAP version of the message sent is always 1.1 because there is no code that changes it.
> I made a patch to the CxfBcProvider class to detect the soap version.
> I dont know if this should be done in an interceptor, i made directly in the CxfBcProvider after retrieving the BindingOperationInfo.
>         // Retrieve the BindingOperationInfo
>         BindingOperationInfo boi = ......;
>         // SOAP 1.2 support
>         String bindingId = boi.getBinding().getBindingId();
>         if (WSDLConstants.SOAP11_NAMESPACE.equals(bindingId)) {
>             message.setVersion(Soap11.getInstance());
>         } else if (WSDLConstants.SOAP12_NAMESPACE.equals(bindingId)) {
>             message.setVersion(Soap12.getInstance());
>         }
> 	    ///////////

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.