You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Frun1na (via GitHub)" <gi...@apache.org> on 2026/10/01 15:25:51 UTC
[PR] fix(group): preview the offset reset from the topic route for stopped groups [rocketmq-dashboard]
Frun1na opened a new pull request, #5291:
URL: https://github.com/apache/rocketmq-dashboard/pull/5291
### Which Issue(s) This PR Fixes
- Fixes #5290
### Brief Description
For a group that ran before and stopped, `examineConsumeStats` throws `CONSUMER_NOT_ONLINE`, the preview returned `allowReset=false` and the UI disabled the confirm button forever - while `resetOffsetNew` itself applies offline. The preview now enumerates the topic route for that case, computes broker-side `min/max/searchOffset` targets per queue, marks current offsets as unknown (`ConsumerLagResolver.UNKNOWN`) with an explicit offline warning, and allows the reset when no queue errored. Broadcast groups and groups that never consumed keep the previous blocking preview (their existing tests pin that intent).
### How Did You Test This Change?
```
cd server && mvn -B -ntp test -Dtest=RocketMQAdminClientImplTest
Tests run: 71, Failures: 0, Errors: 0, Skipped: 0
BUILD SUCCESS
```
---
Re-submission of #4925: the original PR was closed by the stale bot after 7 days without review activity, and GitHub now rejects reopening pull requests in this repository ("state cannot be changed"), so the same change is re-submitted rebased onto the current `rocketmq-studio` tip (`a460673f`). The original review thread stays available at #4925.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(group): preview the offset reset from the topic route for stopped groups [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins merged PR #5291:
URL: https://github.com/apache/rocketmq-dashboard/pull/5291
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(group): preview the offset reset from the topic route for stopped groups [rocketmq-dashboard]
Posted by "Frun1na (via GitHub)" <gi...@apache.org>.
Frun1na commented on PR #5291:
URL: https://github.com/apache/rocketmq-dashboard/pull/5291#issuecomment-6044118021
Friendly ping — this is still open for review whenever you get a chance. (Keeping it from the stale bot for now.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(group): preview the offset reset from the topic route for stopped groups [rocketmq-dashboard]
Posted by "Frun1na (via GitHub)" <gi...@apache.org>.
Frun1na commented on PR #5291:
URL: https://github.com/apache/rocketmq-dashboard/pull/5291#issuecomment-6093178471
Friendly ping — this is still open for review whenever you get a chance. (Keeping it from the stale bot for now.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org