You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "e-mhui (via GitHub)" <gi...@apache.org> on 2023/03/11 13:55:46 UTC
[GitHub] [inlong] e-mhui opened a new pull request, #7570: MongoDB CDC 2.3 supports enabling incremental snapshot
e-mhui opened a new pull request, #7570:
URL: https://github.com/apache/inlong/pull/7570
### Prepare a Pull Request
[INLONG-7537][Sort] MongoDB CDC 2.3 supports enabling incremental snapshot
- Fixes #7537
### Motivation
MongoDB CDC 2.3 supports enabling incremental snapshot
### Modifications
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] e-mhui closed pull request #7570: [INLONG-7537][Sort] Enable incremental snapshot and adapt metrics for MongoDB CDC
Posted by "e-mhui (via GitHub)" <gi...@apache.org>.
e-mhui closed pull request #7570: [INLONG-7537][Sort] Enable incremental snapshot and adapt metrics for MongoDB CDC
URL: https://github.com/apache/inlong/pull/7570
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #7570: [INLONG-7537][Sort] Enable incremental snapshot and adapt metrics for MongoDB CDC
Posted by "healchow (via GitHub)" <gi...@apache.org>.
healchow commented on code in PR #7570:
URL: https://github.com/apache/inlong/pull/7570#discussion_r1133421853
##########
inlong-sort/sort-connectors/cdc-base/src/main/java/org/apache/inlong/sort/cdc/base/config/BaseSourceConfig.java:
##########
@@ -25,7 +25,7 @@
/** A basic Source configuration which is used by {@link IncrementalSource}.
* Copy from com.ververica:flink-cdc-base:2.3.0.
* */
-public abstract class BaseSourceConfig implements SourceConfig {
+public abstract class BaseSourceConfig implements SourceConfig, MetricConfig {
Review Comment:
Please rebase the master branch, as this change was merged in #7568.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] e-mhui commented on a diff in pull request #7570: [INLONG-7537][Sort] Enable incremental snapshot and adapt metrics for MongoDB CDC
Posted by "e-mhui (via GitHub)" <gi...@apache.org>.
e-mhui commented on code in PR #7570:
URL: https://github.com/apache/inlong/pull/7570#discussion_r1133954822
##########
inlong-sort/sort-connectors/cdc-base/src/main/java/org/apache/inlong/sort/cdc/base/config/BaseSourceConfig.java:
##########
@@ -25,7 +25,7 @@
/** A basic Source configuration which is used by {@link IncrementalSource}.
* Copy from com.ververica:flink-cdc-base:2.3.0.
* */
-public abstract class BaseSourceConfig implements SourceConfig {
+public abstract class BaseSourceConfig implements SourceConfig, MetricConfig {
Review Comment:
Thanks you. I'm planning to split this PR into two. Please review this PR https://github.com/apache/inlong/pull/7588 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] e-mhui commented on a diff in pull request #7570: [INLONG-7537][Sort] Enable incremental snapshot and adapt metrics for MongoDB CDC
Posted by "e-mhui (via GitHub)" <gi...@apache.org>.
e-mhui commented on code in PR #7570:
URL: https://github.com/apache/inlong/pull/7570#discussion_r1133954822
##########
inlong-sort/sort-connectors/cdc-base/src/main/java/org/apache/inlong/sort/cdc/base/config/BaseSourceConfig.java:
##########
@@ -25,7 +25,7 @@
/** A basic Source configuration which is used by {@link IncrementalSource}.
* Copy from com.ververica:flink-cdc-base:2.3.0.
* */
-public abstract class BaseSourceConfig implements SourceConfig {
+public abstract class BaseSourceConfig implements SourceConfig, MetricConfig {
Review Comment:
Thank you for your response. I'm planning to split this PR into two. Please review this PR https://github.com/apache/inlong/pull/7588 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org