[GitHub] [hive] sourabh912 commented on a change in pull request #3040: HIVE-25963: Create temporary table with not null constraint gets converted to external table

[GitBox <gi...@apache.org>]

sourabh912 commented on a change in pull request #3040:
URL: https://github.com/apache/hive/pull/3040#discussion_r814207394



##########
File path: ql/src/test/results/clientpositive/llap/enforce_constraint_notnull.q.out
##########
@@ -6411,53 +6364,16 @@ STAGE PLANS:
                     expressions: UDFToInteger(key) (type: int)
                     outputColumnNames: _col0
                     Statistics: Num rows: 500 Data size: 2000 Basic stats: COMPLETE Column stats: COMPLETE
-                    Filter Operator
-                      predicate: enforce_constraint(_col0 is not null) (type: boolean)

Review comment:
       Yes, it means that not null constraint does not have any meaning for temporary tables. Before this patch, a temp table with constraints was getting persisted in metastore and therefore had constraint information persisted. But  after this patch, constraints information will get lost for temporary tables unless we store constraints related info in memory. 
   
   @nrg4878 : Is the behavior for temporary table in terms on constraints as expected after this patch? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org