[GitHub] [arrow-rs] maxburke commented on a diff in pull request #2905: Implement ord for FixedSizeBinary types

[GitBox <gi...@apache.org>]

maxburke commented on code in PR #2905:
URL: https://github.com/apache/arrow-rs/pull/2905#discussion_r1001078616


##########
arrow/src/array/ord.rs:
##########
@@ -295,6 +295,14 @@ pub fn build_compare(left: &dyn Array, right: &dyn Array) -> Result<DynComparato
             let right: Decimal128Array = Decimal128Array::from(right.data().clone());
             Box::new(move |i, j| left.value(i).cmp(&right.value(j)))
         }
+        (FixedSizeBinary(_), FixedSizeBinary(_)) => {

Review Comment:
   That may be but we were running into the unhandled case in this match firing when testing https://github.com/apache/arrow-datafusion/pull/3911



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org