You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by GitBox <gi...@apache.org> on 2019/05/29 08:20:00 UTC
[GitHub] [camel-k] astefanutti commented on a change in pull request #700:
Fix #698: provide a way to override the default image name
astefanutti commented on a change in pull request #700: Fix #698: provide a way to override the default image name
URL: https://github.com/apache/camel-k/pull/700#discussion_r288445548
##########
File path: pkg/apis/camel/v1alpha1/build_types.go
##########
@@ -22,6 +22,7 @@ type BuildSpec struct {
Dependencies []string `json:"dependencies,omitempty"`
Repositories []string `json:"repositories,omitempty"`
BuildDir string `json:"buildDir,omitempty"`
+ BuilderImage string `json:"builderImage,omitempty"`
Review comment:
Ideally, I would avoid exposing a field in public CRDs, solely for testing purpose. There may be a way to retrieve the image form the operator used to run it, and use that image for the other resources.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services