[GitHub] [yunikorn-core] yangwwei commented on pull request #412: [YUNIKORN-1213] Configurable Health Checker Interval

[GitBox <gi...@apache.org>]

yangwwei commented on PR #412:
URL: https://github.com/apache/yunikorn-core/pull/412#issuecomment-1131243553

   hi @surahman  a few high-level feedback:
   
   1. Instead of the following config
   
   ```
   healthcheck:
     enabled: %s
     interval: 99s
   partitions:
     - name: default
       queues:
         - name: root
   ```
   
   what was discussed looks like the following:
   
   ```
   scheduler:
     healthcheck:
       enabled: true
       interval: 30s
   partitions:
     - name: default
        queues:
           - name: root
   ```
   
   We want to include all "global" (non-partition-specific) configs under a single parent "scheduler", including "checksum".  I suggest using another JIRA to track the changes to the "checksum", just to make the PR smaller.
   
   2. Please create a JIRA to track the document changes.
   3. Please make sure the test case includes both having healthcheck section configured and not having this section.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org