You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cayenne.apache.org by "Olga Tkachova (JIRA)" <ji...@apache.org> on 2009/10/15 17:28:32 UTC
[jira] Created: (CAY-1293) Beta 1 Test Failed
Beta 1 Test Failed
------------------
Key: CAY-1293
URL: https://issues.apache.org/jira/browse/CAY-1293
Project: Cayenne
Issue Type: Bug
Reporter: Olga Tkachova
Fix For: 3.0 beta 1
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAY-1293) Beta 1 Test Failed
Posted by "Olga Tkachova (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAY-1293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olga Tkachova updated CAY-1293:
-------------------------------
Attachment: FixErrorsAndFaild.txt
> Beta 1 Test Failed
> ------------------
>
> Key: CAY-1293
> URL: https://issues.apache.org/jira/browse/CAY-1293
> Project: Cayenne
> Issue Type: Bug
> Reporter: Olga Tkachova
> Fix For: 3.0 beta 1
>
> Attachments: FixErrorsAndFaild.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAY-1293) Beta 1 Test Failures
Posted by "Olga Tkachova (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAY-1293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olga Tkachova updated CAY-1293:
-------------------------------
Attachment: FixErrorsAndFaild2.txt
> Beta 1 Test Failures
> --------------------
>
> Key: CAY-1293
> URL: https://issues.apache.org/jira/browse/CAY-1293
> Project: Cayenne
> Issue Type: Bug
> Components: Cayenne Core Library
> Affects Versions: 3.0 beta 1
> Reporter: Olga Tkachova
> Assignee: Andrus Adamchik
> Fix For: 3.0 beta 1
>
> Attachments: FixErrorsAndFaild.txt, FixErrorsAndFaild2.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (CAY-1293) Beta 1 Test Failures
Posted by "Andrus Adamchik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAY-1293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrus Adamchik closed CAY-1293.
--------------------------------
Resolution: Fixed
committed the last patch. Awesome. Thanks!
> Beta 1 Test Failures
> --------------------
>
> Key: CAY-1293
> URL: https://issues.apache.org/jira/browse/CAY-1293
> Project: Cayenne
> Issue Type: Bug
> Components: Cayenne Core Library
> Affects Versions: 3.0 beta 1
> Reporter: Olga Tkachova
> Assignee: Andrus Adamchik
> Fix For: 3.0 beta 1
>
> Attachments: FixErrorsAndFaild.txt, FixErrorsAndFaild2.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAY-1293) Beta 1 Test Failures
Posted by "Andrus Adamchik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAY-1293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrus Adamchik updated CAY-1293:
---------------------------------
Component/s: Cayenne Core Library
Affects Version/s: 3.0 beta 1
Assignee: Andrus Adamchik
Summary: Beta 1 Test Failures (was: Beta 1 Test Failed)
Hi Olga! great job tracking all those obscure bugs. I committed your patch, removing just a few changesets that were simply reformatting the code. I have my doubts about the piece below though. I did not commit it with the rest of the patch, pending a discussion on its purpose.
Index: framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/exp/Expression.java
===================================================================
--- framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/exp/Expression.java (revision 825496)
+++ framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/exp/Expression.java (working copy)
@@ -30,6 +30,7 @@
import java.util.List;
import java.util.Map;
+import org.apache.cayenne.exp.parser.ASTNot;
import org.apache.cayenne.exp.parser.ASTScalar;
import org.apache.cayenne.exp.parser.ExpressionParser;
import org.apache.cayenne.exp.parser.ParseException;
@@ -523,7 +524,9 @@
boolean prune = transformer != null && transformedChild == PRUNED_NODE;
if (!prune) {
- copy.setOperand(j, transformedChild);
+ if (!(copy instanceof ASTNot)) {
+ copy.setOperand(j, transformedChild);
+ }
j++;
}
> Beta 1 Test Failures
> --------------------
>
> Key: CAY-1293
> URL: https://issues.apache.org/jira/browse/CAY-1293
> Project: Cayenne
> Issue Type: Bug
> Components: Cayenne Core Library
> Affects Versions: 3.0 beta 1
> Reporter: Olga Tkachova
> Assignee: Andrus Adamchik
> Fix For: 3.0 beta 1
>
> Attachments: FixErrorsAndFaild.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.