You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/04/29 19:34:43 UTC
[GitHub] [commons-fileupload] arturobernalg opened a new pull request #75: FILEUPLOAD-323 - Implement spotbugs
arturobernalg opened a new pull request #75:
URL: https://github.com/apache/commons-fileupload/pull/75
The idea it's use spotbugs in an intend of find or prevents bugs in Java code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-fileupload] arturobernalg commented on pull request #75: FILEUPLOAD-323 - Implement spotbugs
Posted by GitBox <gi...@apache.org>.
arturobernalg commented on pull request #75:
URL: https://github.com/apache/commons-fileupload/pull/75#issuecomment-829561762
Hi @jochenw
I know there still a lot a work. But what do you think as a first approximation?
TY
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-fileupload] jochenw edited a comment on pull request #75: FILEUPLOAD-323 - Implement spotbugs
Posted by GitBox <gi...@apache.org>.
jochenw edited a comment on pull request #75:
URL: https://github.com/apache/commons-fileupload/pull/75#issuecomment-829981338
I am hesitant. I am fully aware, that commons-lang (as an example) has a rather exhaustive set of rules, that are asserted by Spotbugs, Checkstyle, etc. On the other hand, I notice that I have a tendency to spend more time dealing with Checkstyle, than with the actual coding, if I work on commons-lang. Besides, I'm a member of the "code style's not that important" faction. (Might be my own problem, because I don't use it frequently enough to become really comfortable.)
Perhaps, others might voice an opinion? @garydgregory, @sebbASF, @grobmeier, or @kinow, I'd value your opinion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-fileupload] jochenw merged pull request #75: FILEUPLOAD-323 - Implement spotbugs
Posted by GitBox <gi...@apache.org>.
jochenw merged pull request #75:
URL: https://github.com/apache/commons-fileupload/pull/75
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-fileupload] kinow commented on pull request #75: FILEUPLOAD-323 - Implement spotbugs
Posted by GitBox <gi...@apache.org>.
kinow commented on pull request #75:
URL: https://github.com/apache/commons-fileupload/pull/75#issuecomment-829999881
Hi @jochenw
I also don't have a strong preference. Most times I just try to remember to read some code in the project I'm working on and mimic the code style.
I find SpotBugs/checkstyle/etc helpful when we find a set of rules that allow you to spot simple mistakes, especially those that appear in PR's of first-time contributors, and can be quickly spotted by CI. But agree that some rules can be annoying (e.g. when you wrote a perfectly legible 121 characters line, and checkstyle tells you to reduce in character or add a line break 🤷♂️ ).
I think this PR can be a good initial work for spotbugs. We can tweak it so that it doesn't bother you and others when they need to work on the component, whilst also helping you and other devs to keep the code uniform-ish, and filter simple bugs in CI (i.e. feel free to suggest what rules are being helpful or not, what to disable, etc).
Just my 0.02 cents :o)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-fileupload] jochenw commented on pull request #75: FILEUPLOAD-323 - Implement spotbugs
Posted by GitBox <gi...@apache.org>.
jochenw commented on pull request #75:
URL: https://github.com/apache/commons-fileupload/pull/75#issuecomment-829981338
I am hesitant. I am fully aware, that commons-lang (as an example) has a rather exhaustive set of rules, that are asserted by Spotbugs, Checkstyle, etc. On the other hand, I notice that I have a tendency to spend more time dealing with Spotbugs, than with the actual coding, if I work on commons-lang. Besides, I'm a member of the "code style's not that important" faction. (Might be my own problem, because I don't use it frequently enough to become really comfortable.)
Perhaps, others might voice an opinion? @garydgregory, @sebbASF, @grobmeier, or @kinow, I'd value your opinion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-fileupload] coveralls commented on pull request #75: FILEUPLOAD-323 - Implement spotbugs
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #75:
URL: https://github.com/apache/commons-fileupload/pull/75#issuecomment-829867132
[](https://coveralls.io/builds/39251479)
Coverage remained the same at 78.452% when pulling **92386e20c4f0bed4a2e2781390d63a0685f1760b on arturobernalg:feature/FILEUPLOAD-323** into **d863336acc9d10ea5e6df7ee18d69cdcfb86b26d on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org