You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/04/04 02:19:29 UTC

[GitHub] [incubator-nuttx] yamt commented on a change in pull request #707: Fix make dependency

yamt commented on a change in pull request #707: Fix make dependency
URL: https://github.com/apache/incubator-nuttx/pull/707#discussion_r403410901
 
 

 ##########
 File path: tools/LibTargets.mk
 ##########
 @@ -194,7 +194,11 @@ libs$(DELIM)libxx$(DELIM)libxx$(LIBEXT): pass1dep
 staging$(DELIM)libxx$(LIBEXT): libs$(DELIM)libxx$(DELIM)libxx$(LIBEXT)
 	$(Q) $(call INSTALL_LIB,$<,$@)
 
+ifeq ($(CONFIG_BUILD_PROTECTED),y)
 
 Review comment:
   i haven't tested CONFIG_BUILD_KERNEL.
   my understanding is this doesn't matter for CONFIG_BUILD_KERNEL as it doesn't have libapps either in USERLIBS or NUTTXLIBS.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services