You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "amaliujia (via GitHub)" <gi...@apache.org> on 2023/03/06 21:50:18 UTC

[GitHub] [spark] amaliujia commented on a diff in pull request #40304: [SPARK-42665][CONNECT][Test] Mute Scala Client UDF test

amaliujia commented on code in PR #40304:
URL: https://github.com/apache/spark/pull/40304#discussion_r1127070223


##########
connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/ClientE2ETestSuite.scala:
##########
@@ -76,7 +76,8 @@ class ClientE2ETestSuite extends RemoteSparkSession {
     assert(result(2) == 2)
   }
 
-  test("simple udf") {
+  // TODO (SPARK-42665): Ignore this test until the udf is fully implemented.
+  ignore("simple udf") {

Review Comment:
   nit: I think the common way to do so is this format:
   
   ```  ignore("SPARK-31855: generate test files for checking compatibility with Spark 2.4/3.2") ```.
   
   Basically you leave the SPARK-XXXX and the reason in the test name.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org