You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hive.apache.org by he...@apache.org on 2010/07/05 20:22:07 UTC

svn commit: r960656 - in /hadoop/hive/trunk: CHANGES.txt ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFBridge.java ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBridge.java

Author: heyongqiang
Date: Mon Jul  5 18:22:07 2010
New Revision: 960656

URL: http://svn.apache.org/viewvc?rev=960656&view=rev
Log:
HIVE-1447. Speed up reflection method calls(Zheng via He Yongqiang)

Modified:
    hadoop/hive/trunk/CHANGES.txt
    hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFBridge.java
    hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBridge.java

Modified: hadoop/hive/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/hive/trunk/CHANGES.txt?rev=960656&r1=960655&r2=960656&view=diff
==============================================================================
--- hadoop/hive/trunk/CHANGES.txt (original)
+++ hadoop/hive/trunk/CHANGES.txt Mon Jul  5 18:22:07 2010
@@ -22,6 +22,8 @@ Trunk -  Unreleased
 
     HIVE-1443. Add an API to turn off bucketing (Paul Yang via namit)
 
+    HIVE-1447. Speed up reflection method calls (Zheng via He Yongqiang)
+
   OPTIMIZATIONS
 
   BUG FIXES

Modified: hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFBridge.java
URL: http://svn.apache.org/viewvc/hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFBridge.java?rev=960656&r1=960655&r2=960656&view=diff
==============================================================================
--- hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFBridge.java (original)
+++ hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFBridge.java Mon Jul  5 18:22:07 2010
@@ -104,6 +104,7 @@ public class GenericUDAFBridge implement
 
       // Get the reflection methods from ue
       for (Method method : udafEvaluator.getMethods()) {
+        method.setAccessible(true);
         if (method.getName().equals("iterate")) {
           iterateMethod = method;
         }

Modified: hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBridge.java
URL: http://svn.apache.org/viewvc/hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBridge.java?rev=960656&r1=960655&r2=960656&view=diff
==============================================================================
--- hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBridge.java (original)
+++ hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBridge.java Mon Jul  5 18:22:07 2010
@@ -133,6 +133,7 @@ public class GenericUDFBridge extends Ge
           .getTypeInfoFromObjectInspector(argument));
     }
     udfMethod = udf.getResolver().getEvalMethod(argumentTypeInfos);
+    udfMethod.setAccessible(true);
 
     // Create parameter converters
     conversionHelper = new ConversionHelper(udfMethod, arguments);