You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Mark Eschbach (Created) (JIRA)" <ji...@apache.org> on 2012/02/01 22:26:58 UTC
[jira] [Created] (WICKET-4380) Null url argument on missing static
resource
Null url argument on missing static resource
--------------------------------------------
Key: WICKET-4380
URL: https://issues.apache.org/jira/browse/WICKET-4380
Project: Wicket
Issue Type: Improvement
Components: wicket
Affects Versions: 1.5.4, 1.5.3
Environment: All tested (Jetty via Maven, deploy into Tomcat)
Reporter: Mark Eschbach
Priority: Minor
The WebExternalResourceStream doesn't check the return value of the ServletContext#getResource, which could be null. When the reference is given to the Connections#lastModified method this will cause a complaint several call layers down stating the URL argument may not be null. The null value is a result of the referenced static resource missing, thus the servlet container is correctly returning null (as per the Servlet spec).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (WICKET-4380) Null url argument on missing static
resource
Posted by "Emond Papegaaij (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emond Papegaaij reassigned WICKET-4380:
---------------------------------------
Assignee: Emond Papegaaij
> Null url argument on missing static resource
> --------------------------------------------
>
> Key: WICKET-4380
> URL: https://issues.apache.org/jira/browse/WICKET-4380
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.5.3, 1.5.4
> Environment: All tested (Jetty via Maven, deploy into Tomcat)
> Reporter: Mark Eschbach
> Assignee: Emond Papegaaij
> Priority: Minor
> Attachments: WERS-bug.zip, WERS-npe.patch
>
>
> The WebExternalResourceStream doesn't check the return value of the ServletContext#getResource, which could be null. When the reference is given to the Connections#lastModified method this will cause a complaint several call layers down stating the URL argument may not be null. The null value is a result of the referenced static resource missing, thus the servlet container is correctly returning null (as per the Servlet spec).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4380) Null url argument on missing static
resource
Posted by "Mark Eschbach (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Eschbach updated WICKET-4380:
----------------------------------
Attachment: WERS-npe.patch
Attaching a patch to indicate the given resource could not be located.
This patch was generated by the command `git diff >WERS-npe.patch` from the root of the Git repository on GitHub.
> Null url argument on missing static resource
> --------------------------------------------
>
> Key: WICKET-4380
> URL: https://issues.apache.org/jira/browse/WICKET-4380
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.5.3, 1.5.4
> Environment: All tested (Jetty via Maven, deploy into Tomcat)
> Reporter: Mark Eschbach
> Priority: Minor
> Attachments: WERS-bug.zip, WERS-npe.patch
>
>
> The WebExternalResourceStream doesn't check the return value of the ServletContext#getResource, which could be null. When the reference is given to the Connections#lastModified method this will cause a complaint several call layers down stating the URL argument may not be null. The null value is a result of the referenced static resource missing, thus the servlet container is correctly returning null (as per the Servlet spec).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WICKET-4380) Null url argument on missing static
resource
Posted by "Emond Papegaaij (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emond Papegaaij resolved WICKET-4380.
-------------------------------------
Resolution: Fixed
Fix Version/s: 6.0.0
1.5.5
Thanks for the patch, it's applied.
> Null url argument on missing static resource
> --------------------------------------------
>
> Key: WICKET-4380
> URL: https://issues.apache.org/jira/browse/WICKET-4380
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.5.3, 1.5.4
> Environment: All tested (Jetty via Maven, deploy into Tomcat)
> Reporter: Mark Eschbach
> Assignee: Emond Papegaaij
> Priority: Minor
> Fix For: 1.5.5, 6.0.0
>
> Attachments: WERS-bug.zip, WERS-npe.patch
>
>
> The WebExternalResourceStream doesn't check the return value of the ServletContext#getResource, which could be null. When the reference is given to the Connections#lastModified method this will cause a complaint several call layers down stating the URL argument may not be null. The null value is a result of the referenced static resource missing, thus the servlet container is correctly returning null (as per the Servlet spec).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4380) Null url argument on missing static
resource
Posted by "Mark Eschbach (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Eschbach updated WICKET-4380:
----------------------------------
Attachment: WERS-bug.zip
Attaching an example of the bug triggered with a quickstart project.
> Null url argument on missing static resource
> --------------------------------------------
>
> Key: WICKET-4380
> URL: https://issues.apache.org/jira/browse/WICKET-4380
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.5.3, 1.5.4
> Environment: All tested (Jetty via Maven, deploy into Tomcat)
> Reporter: Mark Eschbach
> Priority: Minor
> Attachments: WERS-bug.zip
>
>
> The WebExternalResourceStream doesn't check the return value of the ServletContext#getResource, which could be null. When the reference is given to the Connections#lastModified method this will cause a complaint several call layers down stating the URL argument may not be null. The null value is a result of the referenced static resource missing, thus the servlet container is correctly returning null (as per the Servlet spec).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira