You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "mabhub (via GitHub)" <gi...@apache.org> on 2023/01/31 17:00:10 UTC
[GitHub] [superset] mabhub opened a new pull request, #22924: fix(plugin): Simplify Peru GeoJSON file (#22923)
mabhub opened a new pull request, #22924:
URL: https://github.com/apache/superset/pull/22924
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Simplify Peru GeoJSON file to have similar précision (and file weight) as other countries.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue: #22923
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #22924: fix(plugin): Simplify Peru GeoJSON file (#22923)
Posted by codecov.
codecov[bot] commented on PR #22924:
URL: https://github.com/apache/superset/pull/22924#issuecomment-1410872162
# [Codecov](https://codecov.io/gh/apache/superset/pull/22924?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#22924](https://codecov.io/gh/apache/superset/pull/22924?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (39c23d3) into [master](https://codecov.io/gh/apache/superset/commit/30abefb519978e2760a492de51dc0d19803edf3a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (30abefb) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #22924 +/- ##
==========================================
+ Coverage 67.36% 67.38% +0.02%
==========================================
Files 1876 1876
Lines 72066 72052 -14
Branches 7868 7862 -6
==========================================
+ Hits 48545 48550 +5
+ Misses 21504 21484 -20
- Partials 2017 2018 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `53.80% <ø> (+0.03%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/22924?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/superset/pull/22924?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL3ByZXNldHMvTWFpblByZXNldC5qcw==) | `100.00% <0.00%> (ø)` | |
| [...plugins/plugin-chart-echarts/src/Sunburst/types.ts](https://codecov.io/gh/apache/superset/pull/22924?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvU3VuYnVyc3QvdHlwZXMudHM=) | `100.00% <0.00%> (ø)` | |
| [...plugin-chart-echarts/src/Sunburst/controlPanel.tsx](https://codecov.io/gh/apache/superset/pull/22924?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvU3VuYnVyc3QvY29udHJvbFBhbmVsLnRzeA==) | `28.57% <0.00%> (ø)` | |
| [...lugin-chart-echarts/src/Sunburst/transformProps.ts](https://codecov.io/gh/apache/superset/pull/22924?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvU3VuYnVyc3QvdHJhbnNmb3JtUHJvcHMudHM=) | `0.00% <0.00%> (ø)` | |
| [...gin-chart-echarts/src/Sunburst/EchartsSunburst.tsx](https://codecov.io/gh/apache/superset/pull/22924?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvU3VuYnVyc3QvRWNoYXJ0c1N1bmJ1cnN0LnRzeA==) | `0.00% <0.00%> (ø)` | |
| [...gins/plugin-chart-echarts/src/utils/treeBuilder.ts](https://codecov.io/gh/apache/superset/pull/22924?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvdXRpbHMvdHJlZUJ1aWxkZXIudHM=) | `88.23% <0.00%> (+0.73%)` | :arrow_up: |
| [...nts/controls/DateFilterControl/DateFilterLabel.tsx](https://codecov.io/gh/apache/superset/pull/22924?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9EYXRlRmlsdGVyTGFiZWwudHN4) | `59.37% <0.00%> (+4.16%)` | :arrow_up: |
| [...plugins/plugin-chart-echarts/src/Sunburst/index.ts](https://codecov.io/gh/apache/superset/pull/22924?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvU3VuYnVyc3QvaW5kZXgudHM=) | `50.00% <0.00%> (+50.00%)` | :arrow_up: |
| [...ntend/plugins/plugin-chart-echarts/src/defaults.ts](https://codecov.io/gh/apache/superset/pull/22924?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvZGVmYXVsdHMudHM=) | `100.00% <0.00%> (+80.00%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #22924: fix(plugin): Simplify Peru GeoJSON file (#22923)
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #22924:
URL: https://github.com/apache/superset/pull/22924#issuecomment-1419604512
> @rusackas It could be that the geojson in this PR is correct, but `d3.geo.centroid` returns wrong center coordinates (and you endup with a map like above) see [d3/d3#1883](https://github.com/d3/d3/issues/1883) or [d3/d3-geo#81](https://github.com/d3/d3-geo/issues/81).
Hmm... could be, but I'm still not sure why this one would be an outlier from the other countries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(plugin): Simplify Peru GeoJSON file (#22923) [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #22924:
URL: https://github.com/apache/superset/pull/22924#issuecomment-1960475959
Closing this... this has been fixed via updates to the Jupyter notebook,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #22924: fix(plugin): Simplify Peru GeoJSON file (#22923)
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #22924:
URL: https://github.com/apache/superset/pull/22924#issuecomment-1410887913
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #22924: fix(plugin): Simplify Peru GeoJSON file (#22923)
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #22924:
URL: https://github.com/apache/superset/pull/22924#issuecomment-1509495288
Check out this blog post, I think this is the answer: https://ruky.me/2023/03/11/how-to-correctly-load-your-country-in-to-apache-superset/
... which probably leads to a bigger project to fix the underlying issue...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(plugin): Simplify Peru GeoJSON file (#22923) [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed pull request #22924: fix(plugin): Simplify Peru GeoJSON file (#22923)
URL: https://github.com/apache/superset/pull/22924
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #22924: fix(plugin): Simplify Peru GeoJSON file (#22923)
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #22924:
URL: https://github.com/apache/superset/pull/22924#issuecomment-1410761729
Thanks for the PR! Updated the PR description to automatically close the PR when this merges. When CI passes, I'll spin up a test environment so any reviewer (myself or otherwise) can play around with it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #22924: fix(plugin): Simplify Peru GeoJSON file (#22923)
Posted by github-actions.
github-actions[bot] commented on PR #22924:
URL: https://github.com/apache/superset/pull/22924#issuecomment-1410889989
@rusackas Ephemeral environment spinning up at http://54.202.252.198:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #22924: fix(plugin): Simplify Peru GeoJSON file (#22923)
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #22924:
URL: https://github.com/apache/superset/pull/22924#issuecomment-1411235789
Hmm... something's not right here. The new map seems to render half the country, and draws a giant bounding box around it, as seen in the "after" screenshot below. You can test it out on the ephemeral environment linked above.
Before:
<img width="431" alt="image" src="https://user-images.githubusercontent.com/812905/215910892-e3350506-c4b2-4c9a-9345-7336bb2dd8a2.png">
Testing on ephemeral environment.
<img width="844" alt="image" src="https://user-images.githubusercontent.com/812905/215911271-bc64aa34-4bb5-4dc9-8811-215675b41876.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kakoni commented on pull request #22924: fix(plugin): Simplify Peru GeoJSON file (#22923)
Posted by "kakoni (via GitHub)" <gi...@apache.org>.
kakoni commented on PR #22924:
URL: https://github.com/apache/superset/pull/22924#issuecomment-1415822928
@rusackas It could be that the geojson in this PR is correct, but ```d3.geo.centroid``` returns wrong center coordinates (and you endup with a map like above) see https://github.com/d3/d3/issues/1883 or https://github.com/d3/d3-geo/issues/81.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org