You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/09/27 14:35:05 UTC
[GitHub] [incubator-iotdb] yuqi1129 opened a new pull request #1774: [IOTDB-920] Disable insert row thats only contains time/timestamp column
yuqi1129 opened a new pull request #1774:
URL: https://github.com/apache/incubator-iotdb/pull/1774
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] yuqi1129 commented on pull request #1774: [IOTDB-920] Disable insert row thats only contains time/timestamp column
Posted by GitBox <gi...@apache.org>.
yuqi1129 commented on pull request #1774:
URL: https://github.com/apache/incubator-iotdb/pull/1774#issuecomment-700412943
@jixuan1989
OK, I will read the guild more carefully and continue to work, thanks for your help
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] mychaow commented on a change in pull request #1774: [IOTDB-920] Disable insert row thats only contains time/timestamp column
Posted by GitBox <gi...@apache.org>.
mychaow commented on a change in pull request #1774:
URL: https://github.com/apache/incubator-iotdb/pull/1774#discussion_r495662971
##########
File path: server/src/main/java/org/apache/iotdb/db/qp/executor/PlanExecutor.java
##########
@@ -145,9 +145,13 @@
import org.apache.iotdb.tsfile.utils.Pair;
import org.apache.iotdb.tsfile.write.schema.MeasurementSchema;
import org.apache.iotdb.tsfile.write.writer.RestorableTsFileIOWriter;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
public class PlanExecutor implements IPlanExecutor {
+ private static final Logger LOG = LoggerFactory.getLogger(PlanExecutor.class);
Review comment:
We usually use logger, maybe you could rename it.
##########
File path: server/src/test/java/org/apache/iotdb/db/integration/IOTDBInsertIT.java
##########
@@ -0,0 +1,104 @@
+package org.apache.iotdb.db.integration;
Review comment:
add license.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] jixuan1989 commented on pull request #1774: [IOTDB-920] Disable insert row thats only contains time/timestamp column
Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on pull request #1774:
URL: https://github.com/apache/incubator-iotdb/pull/1774#issuecomment-700411894
Hi @yuqi, thanks for your contribution!
Haonan mentioned something about the code format style in another PR: we use double blank spaces rather than 4 blank spaces (or tab with 4 blank spaces) for Java Files.
If you use a different code format style, then someone may reformat the file in the future and there will be a lot of meaningless changes.
Read https://iotdb.apache.org/Development/ContributeGuide.html :
```
https://iotdb.apache.org/Development/ContributeGuide.html
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] yuqi1129 commented on pull request #1774: [IOTDB-920] Disable insert row thats only contains time/timestamp column
Posted by GitBox <gi...@apache.org>.
yuqi1129 commented on pull request #1774:
URL: https://github.com/apache/incubator-iotdb/pull/1774#issuecomment-699733519
@HTHou
Yes, i can't figure out why it involved so many files, i will update the code today as it's too late last night when i make the PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] yuqi1129 commented on a change in pull request #1774: [IOTDB-920] Disable insert row thats only contains time/timestamp column
Posted by GitBox <gi...@apache.org>.
yuqi1129 commented on a change in pull request #1774:
URL: https://github.com/apache/incubator-iotdb/pull/1774#discussion_r495670876
##########
File path: server/src/test/java/org/apache/iotdb/db/integration/IOTDBInsertIT.java
##########
@@ -0,0 +1,104 @@
+package org.apache.iotdb.db.integration;
Review comment:
OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] HTHou commented on pull request #1774: [IOTDB-920] Disable insert row thats only contains time/timestamp column
Posted by GitBox <gi...@apache.org>.
HTHou commented on pull request #1774:
URL: https://github.com/apache/incubator-iotdb/pull/1774#issuecomment-699730527
This pr is changing too many files. Please close it, pull master branch again, do the modification and re-submit a pr again. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] yuqi1129 commented on a change in pull request #1774: [IOTDB-920] Disable insert row thats only contains time/timestamp column
Posted by GitBox <gi...@apache.org>.
yuqi1129 commented on a change in pull request #1774:
URL: https://github.com/apache/incubator-iotdb/pull/1774#discussion_r495671002
##########
File path: server/src/main/java/org/apache/iotdb/db/qp/executor/PlanExecutor.java
##########
@@ -145,9 +145,13 @@
import org.apache.iotdb.tsfile.utils.Pair;
import org.apache.iotdb.tsfile.write.schema.MeasurementSchema;
import org.apache.iotdb.tsfile.write.writer.RestorableTsFileIOWriter;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
public class PlanExecutor implements IPlanExecutor {
+ private static final Logger LOG = LoggerFactory.getLogger(PlanExecutor.class);
Review comment:
Sure, if it's the custom
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org