You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/23 20:16:11 UTC

[GitHub] [airflow] eladkal commented on a change in pull request #19789: Fix missing region_name arguments in AWS provider

eladkal commented on a change in pull request #19789:
URL: https://github.com/apache/airflow/pull/19789#discussion_r755472415



##########
File path: airflow/providers/amazon/aws/hooks/base_aws.py
##########
@@ -539,7 +539,7 @@ def expand_role(self, role: str) -> str:
         if "/" in role:
             return role
         else:
-            session, endpoint_url = self._get_credentials()
+            session, endpoint_url = self._get_credentials(region_name=None)

Review comment:
       I don't think so...
   Also lets not add more joy to this party :) 
   adding region_name is enhancement rather than addressing the bug/warnings problem so if someone thinks it's needed we can have it in a separated PR




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org