You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/06/10 13:44:26 UTC

[GitHub] [druid] FrankChen021 commented on pull request #11257: Reduce method invocation of reservoir sampling

FrankChen021 commented on pull request #11257:
URL: https://github.com/apache/druid/pull/11257#issuecomment-858635431


   The new algorithm implementation looks good to me. But it drops the `percentOfSegmentsToConsider` parameter, I have no idea whether it should be kept. What do you think ?  @jihoonson 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org