You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by Leemoonsoo <gi...@git.apache.org> on 2018/10/31 20:57:09 UTC
[GitHub] zeppelin pull request #3213: [ZEPPELIN-3839] Replace | to , in the filename
GitHub user Leemoonsoo opened a pull request:
https://github.com/apache/zeppelin/pull/3213
[ZEPPELIN-3839] Replace | to , in the filename
### What is this PR for?
A tutorial notebook filename, which includes `|`, is not compatible with windows filesystem.
This PR replace `|` with `,`.
### What type of PR is it?
Bug Fix
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-3839
### How should this be tested?
CI pass
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Leemoonsoo/zeppelin ZEPPELIN-3839
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/3213.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3213
----
commit 0c1a5dda86f1aac7ba3813e27ea0ec05c9e13213
Author: Lee moon soo <mo...@...>
Date: 2018-10-31T19:02:58Z
Replace | to , in the filename
----
---
[GitHub] zeppelin pull request #3213: [ZEPPELIN-3839] Replace | to , in the filename
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/3213
---
[GitHub] zeppelin issue #3213: [ZEPPELIN-3839] Replace | to , in the filename
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/3213
Thanks @felixcheung review.
---