(superset) branch master updated: fix(accessibility): logo outline on tab navigation, but not on click (#30077)

[ru...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

rusackas pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 9c3eb8f51f fix(accessibility): logo outline on tab navigation, but not on click (#30077)
9c3eb8f51f is described below

commit 9c3eb8f51f638c11e609032c36011801ae35c38b
Author: Evan Rusackas <ev...@preset.io>
AuthorDate: Tue Sep 3 12:04:22 2024 -0600

    fix(accessibility): logo outline on tab navigation, but not on click (#30077)
---
 superset-frontend/src/features/home/Menu.tsx | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/superset-frontend/src/features/home/Menu.tsx b/superset-frontend/src/features/home/Menu.tsx
index 7afc7fb7ad..3d83aded7c 100644
--- a/superset-frontend/src/features/home/Menu.tsx
+++ b/superset-frontend/src/features/home/Menu.tsx
@@ -68,6 +68,12 @@ const StyledHeader = styled.header`
           height: 100%;
           object-fit: contain;
         }
+        &:focus {
+          border-color: transparent;
+        }
+        &:focus-visible {
+          border-color: ${theme.colors.primary.dark1};
+        }
       }
       .navbar-brand-text {
         border-left: 1px solid ${theme.colors.grayscale.light2};
@@ -306,11 +312,7 @@ export function Menu({
             arrowPointAtCenter
           >
             {isFrontendRoute(window.location.pathname) ? (
-              <GenericLink
-                className="navbar-brand"
-                to={brand.path}
-                tabIndex={-1}
-              >
+              <GenericLink className="navbar-brand" to={brand.path}>
                 <img src={brand.icon} alt={brand.alt} />
               </GenericLink>
             ) : (