You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2017/04/19 12:41:22 UTC

[GitHub] brooklyn-docs pull request #172: Java config docs: default-value should be i...

GitHub user aledsage opened a pull request:

    https://github.com/apache/brooklyn-docs/pull/172

    Java config docs: default-value should be immutable

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aledsage/brooklyn-docs fix-config-defaultVal-must-be-immutable

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-docs/pull/172.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #172
    
----
commit 1bdfa621a2c7476b5dd45a97a852987494b35905
Author: Aled Sage <al...@gmail.com>
Date:   2017-04-19T12:40:37Z

    Java config docs: default-value should be immutable

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-docs issue #172: Java config docs: default-value should be immutabl...

Posted by geomacy <gi...@git.apache.org>.

Github user geomacy commented on the issue:

    https://github.com/apache/brooklyn-docs/pull/172
  
    LGTM, merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-docs pull request #172: Java config docs: default-value should be i...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/brooklyn-docs/pull/172


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-docs issue #172: Java config docs: default-value should be immutabl...

Posted by drigodwin <gi...@git.apache.org>.

Github user drigodwin commented on the issue:

    https://github.com/apache/brooklyn-docs/pull/172
  
    Thanks for the addition @aledsage, do you think this should replace @bostko's #171?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-docs issue #172: Java config docs: default-value should be immutabl...

Posted by nakomis <gi...@git.apache.org>.

Github user nakomis commented on the issue:

    https://github.com/apache/brooklyn-docs/pull/172
  
    I think it would be worth changing the wording to make it clearer that you're not talking about the user *setting* the default to a new value, but instead modifying the underlying object, i.e. the risk isn't that they might say `myConfigKey.setDefaultValue(newValue)`, but rather `myListConfigKey.getDefaultValue().add(foo)`. Perhaps something like:
    
    If supplying an object as a default value, it is important that the object is immutable. Otherwise, it risks users of the blueprint modifying the underlying object, which would affect blueprints that are subsequently deployed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---