You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@asterixdb.apache.org by mb...@apache.org on 2025/08/15 17:50:09 UTC

(asterixdb) 06/17: [NO ISSUE][COMP] Change plan to show RETAIN-UNTRUE for null placeholders

This is an automated email from the ASF dual-hosted git repository.

mblow pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/asterixdb.git

commit eafb1bcc731c4fda21f316813b55008cef98da58
Author: Shahrzad Shirazi <Sh...@couchbase.com>
AuthorDate: Fri Jun 27 16:05:49 2025 -0700

    [NO ISSUE][COMP] Change plan to show RETAIN-UNTRUE for null placeholders
    
    - user model changes: no
    - storage format changes: no
    - interface changes: no
    
    Details:
    Change query plan to show RETAIN-UNTRUE when retaining
    missing even if the placeholder parameter is null.
    
    Ext-ref: MB-67347
    
    Change-Id: I4a3af98be2cf74e837222755abfd45a075b3b257
    Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20004
    Tested-by: Ali Alsuliman <al...@gmail.com>
    Reviewed-by: Ali Alsuliman <al...@gmail.com>
---
 .../algebra/prettyprint/LogicalOperatorPrettyPrintVisitor.java    | 4 ++--
 .../prettyprint/LogicalOperatorPrettyPrintVisitorJson.java        | 8 ++++++++
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitor.java b/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitor.java
index f904c56d78..e113642a41 100644
--- a/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitor.java
+++ b/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitor.java
@@ -300,9 +300,9 @@ public class LogicalOperatorPrettyPrintVisitor extends AbstractLogicalOperatorPr
 
     @Override
     public Void visitSelectOperator(SelectOperator op, Integer indent) throws AlgebricksException {
-        String retainMissing = op.getMissingPlaceholderVariable() != null
+        String retainMissing = (op.getMissingPlaceholderVariable() != null)
                 ? " retain-untrue (" + op.getMissingPlaceholderVariable() + " <- " + op.getRetainMissingAsValue() + ")"
-                : "";
+                : (op.getRetainMissingAsValue() != null ? " retain-untrue" : "");
         addIndent(indent).append("select (").append(op.getCondition().getValue().accept(exprVisitor, indent))
                 .append(")").append(retainMissing)
                 .append(op.isProjectPushed() ? " project: " + str(op.getProjectVariables()) : "");
diff --git a/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitorJson.java b/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitorJson.java
index 3ca1277d5f..9344ae3760 100644
--- a/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitorJson.java
+++ b/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitorJson.java
@@ -781,6 +781,14 @@ public class LogicalOperatorPrettyPrintVisitorJson extends AbstractLogicalOperat
         try {
             jsonGenerator.writeStringField(OPERATOR_FIELD, "select");
             writeStringFieldExpression(CONDITION_FIELD, op.getCondition(), indent);
+            if (op.getRetainMissingAsValue() != null) {
+                LogicalVariable placeholderVar = op.getMissingPlaceholderVariable();
+                IAlgebricksConstantValue retainValue = op.getRetainMissingAsValue();
+                if (placeholderVar != null) {
+                    jsonGenerator.writeStringField("retain-untrue-variable", String.valueOf(placeholderVar));
+                }
+                jsonGenerator.writeStringField("retain-untrue-value", String.valueOf(retainValue));
+            }
             if (op.isProjectPushed()) {
                 writeArrayFieldOfVariables(PROJECT_VARIABLES_FIELD, op.getProjectVariables());
             }