You are viewing a plain text version of this content. The canonical link for it is here.
Posted to ojb-dev@db.apache.org by ar...@apache.org on 2003/11/11 01:14:13 UTC
cvs commit: db-ojb/src/java/org/apache/ojb/broker/accesslayer RowReaderDefaultImpl.java
arminw 2003/11/10 16:14:13
Modified: src/java/org/apache/ojb/broker/accesslayer
RowReaderDefaultImpl.java
Log:
minor improvement, avoid unnecessary object
reference generation.
Revision Changes Path
1.23 +6 -11 db-ojb/src/java/org/apache/ojb/broker/accesslayer/RowReaderDefaultImpl.java
Index: RowReaderDefaultImpl.java
===================================================================
RCS file: /home/cvs/db-ojb/src/java/org/apache/ojb/broker/accesslayer/RowReaderDefaultImpl.java,v
retrieving revision 1.22
retrieving revision 1.23
diff -u -r1.22 -r1.23
--- RowReaderDefaultImpl.java 31 Aug 2003 00:15:03 -0000 1.22
+++ RowReaderDefaultImpl.java 11 Nov 2003 00:14:12 -0000 1.23
@@ -153,17 +153,13 @@
}
int size = fields.length;
- FieldDescriptor fmd = null;
- FieldConversion conversion = null;
Object val = null;
try
{
for (int j = 0; j < size; j++)
{
- fmd = fields[j];
- conversion = fmd.getFieldConversion();
- val = SqlHelper.getObjectFromColumn(rs, fmd);
- row.put(fmd.getColumnName(), conversion.sqlToJava(val));
+ val = SqlHelper.getObjectFromColumn(rs, fields[j]);
+ row.put(fields[j].getColumnName(), fields[j].getFieldConversion().sqlToJava(val));
}
}
catch (SQLException t)
@@ -308,12 +304,11 @@
try
{
FieldDescriptor[] pkFields = m_cld.getPkFields();
+ Object val;
for (int i = 0; i < pkFields.length; i++)
{
- FieldDescriptor fmd = pkFields[i];
- FieldConversion conversion = fmd.getFieldConversion();
- Object val = SqlHelper.getObjectFromColumn(rs, fmd);
- row.put(fmd.getColumnName(), conversion.sqlToJava(val));
+ val = SqlHelper.getObjectFromColumn(rs, pkFields[i]);
+ row.put(pkFields[i].getColumnName(), pkFields[i].getFieldConversion().sqlToJava(val));
}
}
catch (SQLException t)
---------------------------------------------------------------------
To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
For additional commands, e-mail: ojb-dev-help@db.apache.org