You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org> on 2008/11/11 16:48:44 UTC
[jira] Created: (QPID-1454) NullPointerException in
AMQProtocolHandler
NullPointerException in AMQProtocolHandler
------------------------------------------
Key: QPID-1454
URL: https://issues.apache.org/jira/browse/QPID-1454
Project: Qpid
Issue Type: Bug
Components: Java Client
Reporter: Martin Ritchie
Assignee: Martin Ritchie
Priority: Blocker
Fix For: M4
During a test run I managed to get this:
java.lang.NullPointerException
at org.apache.qpid.client.protocol.AMQProtocolHandler.blockUntilNotFailingOver(AMQProtocolHandler.java:779)
at org.apache.qpid.client.AMQConnection.blockUntilNotFailingOver(AMQConnection.java:1214)
at org.apache.qpid.client.AMQConnectionDelegate_8_0.executeRetrySupport(AMQConnectionDelegate_8_0.java:257)
at org.apache.qpid.client.AMQConnection.executeRetrySupport(AMQConnection.java:634)
at org.apache.qpid.client.failover.FailoverRetrySupport.execute(FailoverRetrySupport.java:102)
at org.apache.qpid.client.AMQSession.createConsumerImpl(AMQSession.java:1648)
at org.apache.qpid.client.AMQSession.createConsumer(AMQSession.java:837)
at org.apache.qpid.server.security.acl.SimpleACLTest.testServerPublishInvalidQueueSuccess(SimpleACLTest.java:616)
at org.apache.qpid.test.utils.QpidTestCase.runBare(QpidTestCase.java:188)
at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:222)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (QPID-1454) NullPointerException in
AMQProtocolHandler
Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Ritchie updated QPID-1454:
---------------------------------
Status: Ready To Review (was: In Progress)
> NullPointerException in AMQProtocolHandler
> ------------------------------------------
>
> Key: QPID-1454
> URL: https://issues.apache.org/jira/browse/QPID-1454
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Reporter: Martin Ritchie
> Assignee: Martin Ritchie
> Fix For: M4
>
>
> During a test run I managed to get this:
> java.lang.NullPointerException
> at org.apache.qpid.client.protocol.AMQProtocolHandler.blockUntilNotFailingOver(AMQProtocolHandler.java:779)
> at org.apache.qpid.client.AMQConnection.blockUntilNotFailingOver(AMQConnection.java:1214)
> at org.apache.qpid.client.AMQConnectionDelegate_8_0.executeRetrySupport(AMQConnectionDelegate_8_0.java:257)
> at org.apache.qpid.client.AMQConnection.executeRetrySupport(AMQConnection.java:634)
> at org.apache.qpid.client.failover.FailoverRetrySupport.execute(FailoverRetrySupport.java:102)
> at org.apache.qpid.client.AMQSession.createConsumerImpl(AMQSession.java:1648)
> at org.apache.qpid.client.AMQSession.createConsumer(AMQSession.java:837)
> at org.apache.qpid.server.security.acl.SimpleACLTest.testServerPublishInvalidQueueSuccess(SimpleACLTest.java:616)
> at org.apache.qpid.test.utils.QpidTestCase.runBare(QpidTestCase.java:188)
> at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:222)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (QPID-1454) NullPointerException in
AMQProtocolHandler
Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Ritchie reassigned QPID-1454:
------------------------------------
Assignee: Aidan Skinner (was: Martin Ritchie)
Aidan, can you review this change.
There is no test as this is a race condition change.
The test would change the value of _failoverLatch between the null check and the await() call.
I can write a multi hreaded test that would do this but it it would not be guaranteed to show the problem.
> NullPointerException in AMQProtocolHandler
> ------------------------------------------
>
> Key: QPID-1454
> URL: https://issues.apache.org/jira/browse/QPID-1454
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Reporter: Martin Ritchie
> Assignee: Aidan Skinner
> Fix For: M4
>
>
> During a test run I managed to get this:
> java.lang.NullPointerException
> at org.apache.qpid.client.protocol.AMQProtocolHandler.blockUntilNotFailingOver(AMQProtocolHandler.java:779)
> at org.apache.qpid.client.AMQConnection.blockUntilNotFailingOver(AMQConnection.java:1214)
> at org.apache.qpid.client.AMQConnectionDelegate_8_0.executeRetrySupport(AMQConnectionDelegate_8_0.java:257)
> at org.apache.qpid.client.AMQConnection.executeRetrySupport(AMQConnection.java:634)
> at org.apache.qpid.client.failover.FailoverRetrySupport.execute(FailoverRetrySupport.java:102)
> at org.apache.qpid.client.AMQSession.createConsumerImpl(AMQSession.java:1648)
> at org.apache.qpid.client.AMQSession.createConsumer(AMQSession.java:837)
> at org.apache.qpid.server.security.acl.SimpleACLTest.testServerPublishInvalidQueueSuccess(SimpleACLTest.java:616)
> at org.apache.qpid.test.utils.QpidTestCase.runBare(QpidTestCase.java:188)
> at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:222)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (QPID-1454) NullPointerException in
AMQProtocolHandler
Posted by "Aidan Skinner (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aidan Skinner updated QPID-1454:
--------------------------------
Priority: Major (was: Blocker)
For this to be a problem you have to be blocking failover from occuring.
> NullPointerException in AMQProtocolHandler
> ------------------------------------------
>
> Key: QPID-1454
> URL: https://issues.apache.org/jira/browse/QPID-1454
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Reporter: Martin Ritchie
> Assignee: Martin Ritchie
> Fix For: M4
>
>
> During a test run I managed to get this:
> java.lang.NullPointerException
> at org.apache.qpid.client.protocol.AMQProtocolHandler.blockUntilNotFailingOver(AMQProtocolHandler.java:779)
> at org.apache.qpid.client.AMQConnection.blockUntilNotFailingOver(AMQConnection.java:1214)
> at org.apache.qpid.client.AMQConnectionDelegate_8_0.executeRetrySupport(AMQConnectionDelegate_8_0.java:257)
> at org.apache.qpid.client.AMQConnection.executeRetrySupport(AMQConnection.java:634)
> at org.apache.qpid.client.failover.FailoverRetrySupport.execute(FailoverRetrySupport.java:102)
> at org.apache.qpid.client.AMQSession.createConsumerImpl(AMQSession.java:1648)
> at org.apache.qpid.client.AMQSession.createConsumer(AMQSession.java:837)
> at org.apache.qpid.server.security.acl.SimpleACLTest.testServerPublishInvalidQueueSuccess(SimpleACLTest.java:616)
> at org.apache.qpid.test.utils.QpidTestCase.runBare(QpidTestCase.java:188)
> at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:222)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (QPID-1454) NullPointerException in
AMQProtocolHandler
Posted by "Aidan Skinner (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aidan Skinner resolved QPID-1454.
---------------------------------
Resolution: Fixed
I'm ok with this change, but it did expose the Loathing I have for FailoverHandler.run and it's locky mclockster locktasticness, so I raised QPID-1516 as a result.
> NullPointerException in AMQProtocolHandler
> ------------------------------------------
>
> Key: QPID-1454
> URL: https://issues.apache.org/jira/browse/QPID-1454
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Reporter: Martin Ritchie
> Assignee: Aidan Skinner
> Fix For: M4
>
>
> During a test run I managed to get this:
> java.lang.NullPointerException
> at org.apache.qpid.client.protocol.AMQProtocolHandler.blockUntilNotFailingOver(AMQProtocolHandler.java:779)
> at org.apache.qpid.client.AMQConnection.blockUntilNotFailingOver(AMQConnection.java:1214)
> at org.apache.qpid.client.AMQConnectionDelegate_8_0.executeRetrySupport(AMQConnectionDelegate_8_0.java:257)
> at org.apache.qpid.client.AMQConnection.executeRetrySupport(AMQConnection.java:634)
> at org.apache.qpid.client.failover.FailoverRetrySupport.execute(FailoverRetrySupport.java:102)
> at org.apache.qpid.client.AMQSession.createConsumerImpl(AMQSession.java:1648)
> at org.apache.qpid.client.AMQSession.createConsumer(AMQSession.java:837)
> at org.apache.qpid.server.security.acl.SimpleACLTest.testServerPublishInvalidQueueSuccess(SimpleACLTest.java:616)
> at org.apache.qpid.test.utils.QpidTestCase.runBare(QpidTestCase.java:188)
> at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:222)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.