[GitHub] [spark] asmello commented on issue #24121: [SPARK-26979][PYTHON][FOLLOW-UP] Make binary math/string functions take string as columns as well

[GitBox <gi...@apache.org>]

asmello commented on issue #24121: [SPARK-26979][PYTHON][FOLLOW-UP] Make binary math/string functions take string as columns as well
URL: https://github.com/apache/spark/pull/24121#issuecomment-473813359
 
 
   I'm definitely in favour of the change in how math functions work. Somehow I missed that cast to float, so I thought they just passed the argument directly when given a string (which would've worked, since the Scala API has string overloads for all math functions). So this is something I should've included in my PR.
   
   I'll add some inline comments for stuff I disagree with.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org