You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/10/25 17:42:33 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #2107: build: Makefile should reference CONFIG_HOST_xxx

xiaoxiang781216 opened a new pull request #2107:
URL: https://github.com/apache/incubator-nuttx/pull/2107


   ## Summary
   to unify the host detection logic.
   
   ## Impact
   build on cygwin and msys2
   
   ## Testing
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] btashton commented on pull request #2107: build: Makefile should reference CONFIG_HOST_xxx

Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #2107:
URL: https://github.com/apache/incubator-nuttx/pull/2107#issuecomment-748763845


   Sure, I can also do some windows builds. Need to look at msys I have not built with it in some time. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2107: build: Makefile should reference CONFIG_HOST_xxx

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #2107:
URL: https://github.com/apache/incubator-nuttx/pull/2107#issuecomment-813065036


   > Sure, I can also do some windows builds. Need to look at msys I have not built with it in some time.
   
   @btashton the build script doesn't do the special action for msys, so the change should be work with msys.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] btashton merged pull request #2107: build: Makefile should reference CONFIG_HOST_xxx

Posted by GitBox <gi...@apache.org>.
btashton merged pull request #2107:
URL: https://github.com/apache/incubator-nuttx/pull/2107


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2107: build: Makefile should reference CONFIG_HOST_xxx

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #2107:
URL: https://github.com/apache/incubator-nuttx/pull/2107#issuecomment-748763257


   @btashton could you help review this PR?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org