[GitHub] [guacamole-client] jmuehlner commented on a diff in pull request #779: GUACAMOLE-1772: Allow user configuration of KSM API call timeout.

[GitBox <gi...@apache.org>]

jmuehlner commented on code in PR #779:
URL: https://github.com/apache/guacamole-client/pull/779#discussion_r1035282766


##########
extensions/guacamole-vault/modules/guacamole-vault-ksm/src/main/java/org/apache/guacamole/vault/ksm/conf/KsmConfigurationService.java:
##########
@@ -176,6 +188,20 @@ public boolean getMatchUserRecordsByDomain() throws GuacamoleException {
         return environment.getProperty(MATCH_USER_DOMAINS, false);
     }
 
+    /**
+     * Return the minimum number of milliseconds between KSM API calls. If not
+     * otherwise configured, this value will be 60 seconds.
+     *
+     * @return
+     *     The minimum number of milliseconds between KSM API calls.
+     *
+     * @throws GuacamoleException
+     *     If the value specified within guacamole.properties cannot be
+     *     parsed or does not exist.
+     */
+    public long getKsmApiTimeout() throws GuacamoleException {
+        return environment.getProperty(KSM_API_CALL_TIMEOUT, 60000L);

Review Comment:
   The original default timeout was 5 seconds, which means that under heavy load, an entire monthly API call budget could be used up in a bit over 3 hours (the base subscription includes 2500 calls / month).
   
   At 60 seconds, the budget would stretch to nearly 2 days.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org