You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/02/07 17:33:22 UTC
[GitHub] [hbase] ndimiduk opened a new pull request #1143: Backport
HBASE-15519, HBASE-23364, HBASE-23802 to branch-2.2
ndimiduk opened a new pull request #1143: Backport HBASE-15519, HBASE-23364, HBASE-23802 to branch-2.2
URL: https://github.com/apache/hbase/pull/1143
This PR brings back HBASE-15519 and HBASE-23364 as prerequisites to HBASE-23802. They do not cherry-pick cleanly because of the presence of hbtop on branch-2; I had to unwind some minor complications that appear to arrive via HBASE-23065.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ndimiduk commented on issue #1143: Backport HBASE-15519,
HBASE-23364, HBASE-23802 to branch-2.2
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on issue #1143: Backport HBASE-15519, HBASE-23364, HBASE-23802 to branch-2.2
URL: https://github.com/apache/hbase/pull/1143#issuecomment-583522170
Reviewers: see associated discussion on https://issues.apache.org/jira/browse/HBASE-23802.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ndimiduk closed pull request #1143: Backport HBASE-15519,
HBASE-23364, HBASE-23802 to branch-2.2
Posted by GitBox <gi...@apache.org>.
ndimiduk closed pull request #1143: Backport HBASE-15519, HBASE-23364, HBASE-23802 to branch-2.2
URL: https://github.com/apache/hbase/pull/1143
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ndimiduk commented on issue #1143: Backport HBASE-15519,
HBASE-23364, HBASE-23802 to branch-2.2
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on issue #1143: Backport HBASE-15519, HBASE-23364, HBASE-23802 to branch-2.2
URL: https://github.com/apache/hbase/pull/1143#issuecomment-584365689
I think these additional back ports don't make sense for branch-2.2. Closing this one out in favor a of a simplified patch that addresses only the issue as described in the JIRA that's being back ported.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1143: Backport HBASE-15519,
HBASE-23364, HBASE-23802 to branch-2.2
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1143: Backport HBASE-15519, HBASE-23364, HBASE-23802 to branch-2.2
URL: https://github.com/apache/hbase/pull/1143#issuecomment-583644663
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 14s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 4 new or modified test files. |
||| _ branch-2.2 Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 5m 39s | branch-2.2 passed |
| +1 :green_heart: | compile | 1m 30s | branch-2.2 passed |
| +1 :green_heart: | checkstyle | 1m 57s | branch-2.2 passed |
| +1 :green_heart: | shadedjars | 4m 27s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 4s | branch-2.2 passed |
| +0 :ok: | spotbugs | 3m 15s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 4m 8s | branch-2.2 passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 5m 18s | the patch passed |
| +1 :green_heart: | compile | 1m 30s | the patch passed |
| +1 :green_heart: | javac | 1m 30s | the patch passed |
| -1 :x: | checkstyle | 1m 30s | hbase-server: The patch generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedjars | 4m 24s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 16m 46s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
| +1 :green_heart: | javadoc | 1m 3s | the patch passed |
| +1 :green_heart: | findbugs | 4m 40s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 32s | hbase-hadoop-compat in the patch passed. |
| +1 :green_heart: | unit | 0m 39s | hbase-hadoop2-compat in the patch passed. |
| -1 :x: | unit | 230m 8s | hbase-server in the patch failed. |
| +1 :green_heart: | asflicense | 1m 11s | The patch does not generate ASF License warnings. |
| | | 295m 27s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.hbase.client.TestAdmin1 |
| | hadoop.hbase.replication.multiwal.TestReplicationSyncUpToolWithMultipleWAL |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1143/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1143 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux e12b4e794ce5 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1143/out/precommit/personality/provided.sh |
| git revision | branch-2.2 / 4094275cd0 |
| Default Java | 1.8.0_181 |
| checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1143/1/artifact/out/diff-checkstyle-hbase-server.txt |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1143/1/artifact/out/patch-unit-hbase-server.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1143/1/testReport/ |
| Max. process+thread count | 4674 (vs. ulimit of 10000) |
| modules | C: hbase-hadoop-compat hbase-hadoop2-compat hbase-server U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1143/1/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services