You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Sean Busbey (JIRA)" <ji...@apache.org> on 2017/07/06 19:59:00 UTC

[jira] [Updated] (HBASE-18327) redo test-patch personality 'hadoopcheck' to better account for feature branches

     [ https://issues.apache.org/jira/browse/HBASE-18327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sean Busbey updated HBASE-18327:
--------------------------------
    Attachment: HBASE-18327.0.patch

> redo test-patch personality 'hadoopcheck' to better account for feature branches
> --------------------------------------------------------------------------------
>
>                 Key: HBASE-18327
>                 URL: https://issues.apache.org/jira/browse/HBASE-18327
>             Project: HBase
>          Issue Type: Improvement
>          Components: build, test
>            Reporter: Sean Busbey
>            Assignee: Sean Busbey
>            Priority: Minor
>         Attachments: HBASE-18327.0.patch
>
>
> right now our 'which hadoop checks do we need' check looks like this:
> {code}
>   if [[ "${PATCH_BRANCH}" = "master" ]]; then
>     hbase_hadoop2_versions=${HBASE_MASTER_HADOOP2_VERSIONS}
>     hbase_hadoop3_versions=${HBASE_MASTER_HADOOP3_VERSIONS}
>   elif [[ ${PATCH_BRANCH} = branch-2* ]]; then
>     hbase_hadoop2_versions=${HBASE_BRANCH2_HADOOP2_VERSIONS}
>     hbase_hadoop3_versions=${HBASE_BRANCH2_HADOOP3_VERSIONS}
>   else
>     hbase_hadoop2_versions=${HBASE_HADOOP2_VERSIONS}
>     hbase_hadoop3_versions=${HBASE_HADOOP3_VERSIONS}
>   fi
> {code}
> the check is basically "if master do this, if like branch-2 do that, otherwise behave like branch-1".
> we often have feature branches that thus end up being treated like branch-1, even though those branches should all be based off of master. (since we follow a master-first development approach.)
> we should redo this check so it's "if branch-1 do this, if branch-2 do that, otherwise behave like master"



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)