You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2022/04/29 08:48:47 UTC
[GitHub] [thrift] Jimexist opened a new pull request, #2596: add GitHub action for python 2.x and 3.x
Jimexist opened a new pull request, #2596:
URL: https://github.com/apache/thrift/pull/2596
<!-- Explain the changes in the pull request below: -->
<!-- We recommend you review the checklist/tips before submitting a pull request. -->
- [ ] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not required for trivial changes)
- [ ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
- [ ] Did you squash your changes to a single commit? (not required, but preferred)
- [ ] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
- [ ] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jimexist commented on a diff in pull request #2596: THRIFT-5564: add GitHub action for python 2.x and 3.x
Posted by GitBox <gi...@apache.org>.
Jimexist commented on code in PR #2596:
URL: https://github.com/apache/thrift/pull/2596#discussion_r867282209
##########
.github/workflows/build.yml:
##########
@@ -128,3 +128,171 @@ jobs:
- name: Run make kotlin
run: make -C lib/kotlin
+
+ lib-rust:
Review Comment:
yes it's actually based on:
- #2594
but i think we can merge in one pass as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jimexist commented on a diff in pull request #2596: THRIFT-5564: add GitHub action for python 2.x and 3.x
Posted by GitBox <gi...@apache.org>.
Jimexist commented on code in PR #2596:
URL: https://github.com/apache/thrift/pull/2596#discussion_r867282347
##########
.github/workflows/build.yml:
##########
@@ -128,3 +128,171 @@ jobs:
- name: Run make kotlin
run: make -C lib/kotlin
+
+ lib-rust:
+ needs: compiler
+ runs-on: ubuntu-20.04
+ env:
+ TOOLCHAIN_VERSION: 1.40.0
+ steps:
+ - uses: actions/checkout@v3
+
+ - name: Install dependencies
+ run: |
+ sudo apt-get update -yq
+ sudo apt-get install -y --no-install-recommends $BUILD_DEPS
+ sudo apt-get install -y --no-install-recommends curl
+
+ - name: Setup cargo
+ run: |
+ curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y
+ rustup update
+ rustup install $TOOLCHAIN_VERSION
+ rustup default $TOOLCHAIN_VERSION
+ rustup --version
+ cargo --version
+ rustc --version
+
+ - name: Run bootstrap
+ run: ./bootstrap.sh
+
+ - name: Run configure
+ run: |
+ ./configure \
+ --disable-debug \
+ --disable-tests \
+ --disable-dependency-tracking \
+ --without-cpp \
+ --without-c_glib \
+ --without-java \
+ --without-kotlin \
+ --without-python \
+ --without-py3 \
+ --without-ruby \
+ --without-haxe \
+ --without-netstd \
+ --without-perl \
+ --without-php \
+ --without-php_extension \
+ --without-dart \
+ --without-erlang \
+ --without-go \
+ --without-d \
+ --without-nodejs \
+ --without-nodets \
+ --without-lua \
+ --with-rs \
+ --without-swift
+
+ - uses: actions/download-artifact@v3
+ with:
+ name: thrift-compiler
+ path: compiler/cpp
+
+ - name: Run thrift-compiler
+ run: |
+ chmod a+x compiler/cpp/thrift
+ compiler/cpp/thrift -version
+
+ - name: Run make rust
+ run: make -C lib/rs
+
+ lib-python:
+ needs: compiler
+ runs-on: ubuntu-20.04
Review Comment:
i'm adding matrix to the compiler part but for python i think it's okay to have just one - given how libraries and compilers are in many cases compiled, installed, and used separately. the matrix should be focusing on multiple python versions for this part.
##########
.github/workflows/build.yml:
##########
@@ -128,3 +128,171 @@ jobs:
- name: Run make kotlin
run: make -C lib/kotlin
+
+ lib-rust:
+ needs: compiler
+ runs-on: ubuntu-20.04
+ env:
+ TOOLCHAIN_VERSION: 1.40.0
+ steps:
+ - uses: actions/checkout@v3
+
+ - name: Install dependencies
+ run: |
+ sudo apt-get update -yq
+ sudo apt-get install -y --no-install-recommends $BUILD_DEPS
+ sudo apt-get install -y --no-install-recommends curl
+
+ - name: Setup cargo
+ run: |
+ curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y
+ rustup update
+ rustup install $TOOLCHAIN_VERSION
+ rustup default $TOOLCHAIN_VERSION
+ rustup --version
+ cargo --version
+ rustc --version
+
+ - name: Run bootstrap
+ run: ./bootstrap.sh
+
+ - name: Run configure
+ run: |
+ ./configure \
+ --disable-debug \
+ --disable-tests \
+ --disable-dependency-tracking \
+ --without-cpp \
+ --without-c_glib \
+ --without-java \
+ --without-kotlin \
+ --without-python \
+ --without-py3 \
+ --without-ruby \
+ --without-haxe \
+ --without-netstd \
+ --without-perl \
+ --without-php \
+ --without-php_extension \
+ --without-dart \
+ --without-erlang \
+ --without-go \
+ --without-d \
+ --without-nodejs \
+ --without-nodets \
+ --without-lua \
+ --with-rs \
+ --without-swift
+
+ - uses: actions/download-artifact@v3
+ with:
+ name: thrift-compiler
+ path: compiler/cpp
+
+ - name: Run thrift-compiler
+ run: |
+ chmod a+x compiler/cpp/thrift
+ compiler/cpp/thrift -version
+
+ - name: Run make rust
+ run: make -C lib/rs
+
+ lib-python:
+ needs: compiler
+ runs-on: ubuntu-20.04
+ strategy:
+ matrix:
+ python-version: ["2.x", "3.x"]
+ steps:
+ - uses: actions/checkout@v3
+
+ - name: Install dependencies
+ run: |
+ sudo apt-get update -yq
+ sudo apt-get install -y --no-install-recommends $BUILD_DEPS
+ sudo apt-get install -y --no-install-recommends curl
+
+ - name: Set up Python
+ uses: actions/setup-python@v3
+ with:
+ python-version: ${{ matrix.python-version }}
+
+ - name: Python setup
+ run: |
+ python -m pip install --upgrade pip setuptools wheel flake8
+ python --version
+ pip --version
+
+ - name: Run bootstrap
+ run: ./bootstrap.sh
+
+ - name: Run configure 2.x
+ if: matrix.python-version == '2.x'
+ run: |
+ ./configure \
+ --disable-debug \
+ --disable-tests \
+ --disable-dependency-tracking \
+ --without-cpp \
+ --without-c_glib \
+ --without-java \
+ --without-kotlin \
+ --with-python \
+ --without-py3 \
+ --without-ruby \
+ --without-haxe \
+ --without-netstd \
+ --without-perl \
+ --without-php \
+ --without-php_extension \
+ --without-dart \
+ --without-erlang \
+ --without-go \
+ --without-d \
+ --without-nodejs \
+ --without-nodets \
+ --without-lua \
+ --without-rs \
+ --without-swift
+
+ - name: Run configure 3.x
+ if: matrix.python-version == '3.x'
+ run: |
+ ./configure \
+ --disable-debug \
+ --disable-tests \
+ --disable-dependency-tracking \
+ --without-cpp \
+ --without-c_glib \
+ --without-java \
+ --without-kotlin \
+ --without-python \
+ --with-py3 \
+ --without-ruby \
+ --without-haxe \
+ --without-netstd \
+ --without-perl \
+ --without-php \
+ --without-php_extension \
+ --without-dart \
+ --without-erlang \
+ --without-go \
+ --without-d \
+ --without-nodejs \
+ --without-nodets \
+ --without-lua \
+ --without-rs \
+ --without-swift
+
+ - uses: actions/download-artifact@v3
+ with:
+ name: thrift-compiler
+ path: compiler/cpp
+
+ - name: Run thrift-compiler
+ run: |
+ chmod a+x compiler/cpp/thrift
+ compiler/cpp/thrift -version
+
+ - name: Run make python
+ run: make -C lib/py
Review Comment:
thanks - i added the check below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] fishy commented on a diff in pull request #2596: THRIFT-5564: add GitHub action for python 2.x and 3.x
Posted by GitBox <gi...@apache.org>.
fishy commented on code in PR #2596:
URL: https://github.com/apache/thrift/pull/2596#discussion_r867014288
##########
.github/workflows/build.yml:
##########
@@ -128,3 +128,171 @@ jobs:
- name: Run make kotlin
run: make -C lib/kotlin
+
+ lib-rust:
+ needs: compiler
+ runs-on: ubuntu-20.04
+ env:
+ TOOLCHAIN_VERSION: 1.40.0
+ steps:
+ - uses: actions/checkout@v3
+
+ - name: Install dependencies
+ run: |
+ sudo apt-get update -yq
+ sudo apt-get install -y --no-install-recommends $BUILD_DEPS
+ sudo apt-get install -y --no-install-recommends curl
+
+ - name: Setup cargo
+ run: |
+ curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y
+ rustup update
+ rustup install $TOOLCHAIN_VERSION
+ rustup default $TOOLCHAIN_VERSION
+ rustup --version
+ cargo --version
+ rustc --version
+
+ - name: Run bootstrap
+ run: ./bootstrap.sh
+
+ - name: Run configure
+ run: |
+ ./configure \
+ --disable-debug \
+ --disable-tests \
+ --disable-dependency-tracking \
+ --without-cpp \
+ --without-c_glib \
+ --without-java \
+ --without-kotlin \
+ --without-python \
+ --without-py3 \
+ --without-ruby \
+ --without-haxe \
+ --without-netstd \
+ --without-perl \
+ --without-php \
+ --without-php_extension \
+ --without-dart \
+ --without-erlang \
+ --without-go \
+ --without-d \
+ --without-nodejs \
+ --without-nodets \
+ --without-lua \
+ --with-rs \
+ --without-swift
+
+ - uses: actions/download-artifact@v3
+ with:
+ name: thrift-compiler
+ path: compiler/cpp
+
+ - name: Run thrift-compiler
+ run: |
+ chmod a+x compiler/cpp/thrift
+ compiler/cpp/thrift -version
+
+ - name: Run make rust
+ run: make -C lib/rs
+
+ lib-python:
+ needs: compiler
+ runs-on: ubuntu-20.04
Review Comment:
should we also make this part of the matrix? my understanding is that this is not the only version of ubuntu we want to support.
##########
.github/workflows/build.yml:
##########
@@ -128,3 +128,171 @@ jobs:
- name: Run make kotlin
run: make -C lib/kotlin
+
+ lib-rust:
+ needs: compiler
+ runs-on: ubuntu-20.04
+ env:
+ TOOLCHAIN_VERSION: 1.40.0
+ steps:
+ - uses: actions/checkout@v3
+
+ - name: Install dependencies
+ run: |
+ sudo apt-get update -yq
+ sudo apt-get install -y --no-install-recommends $BUILD_DEPS
+ sudo apt-get install -y --no-install-recommends curl
+
+ - name: Setup cargo
+ run: |
+ curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y
+ rustup update
+ rustup install $TOOLCHAIN_VERSION
+ rustup default $TOOLCHAIN_VERSION
+ rustup --version
+ cargo --version
+ rustc --version
+
+ - name: Run bootstrap
+ run: ./bootstrap.sh
+
+ - name: Run configure
+ run: |
+ ./configure \
+ --disable-debug \
+ --disable-tests \
+ --disable-dependency-tracking \
+ --without-cpp \
+ --without-c_glib \
+ --without-java \
+ --without-kotlin \
+ --without-python \
+ --without-py3 \
+ --without-ruby \
+ --without-haxe \
+ --without-netstd \
+ --without-perl \
+ --without-php \
+ --without-php_extension \
+ --without-dart \
+ --without-erlang \
+ --without-go \
+ --without-d \
+ --without-nodejs \
+ --without-nodets \
+ --without-lua \
+ --with-rs \
+ --without-swift
+
+ - uses: actions/download-artifact@v3
+ with:
+ name: thrift-compiler
+ path: compiler/cpp
+
+ - name: Run thrift-compiler
+ run: |
+ chmod a+x compiler/cpp/thrift
+ compiler/cpp/thrift -version
+
+ - name: Run make rust
+ run: make -C lib/rs
+
+ lib-python:
+ needs: compiler
+ runs-on: ubuntu-20.04
+ strategy:
+ matrix:
+ python-version: ["2.x", "3.x"]
+ steps:
+ - uses: actions/checkout@v3
+
+ - name: Install dependencies
+ run: |
+ sudo apt-get update -yq
+ sudo apt-get install -y --no-install-recommends $BUILD_DEPS
+ sudo apt-get install -y --no-install-recommends curl
+
+ - name: Set up Python
+ uses: actions/setup-python@v3
+ with:
+ python-version: ${{ matrix.python-version }}
+
+ - name: Python setup
+ run: |
+ python -m pip install --upgrade pip setuptools wheel flake8
+ python --version
+ pip --version
+
+ - name: Run bootstrap
+ run: ./bootstrap.sh
+
+ - name: Run configure 2.x
+ if: matrix.python-version == '2.x'
+ run: |
+ ./configure \
+ --disable-debug \
+ --disable-tests \
+ --disable-dependency-tracking \
+ --without-cpp \
+ --without-c_glib \
+ --without-java \
+ --without-kotlin \
+ --with-python \
+ --without-py3 \
+ --without-ruby \
+ --without-haxe \
+ --without-netstd \
+ --without-perl \
+ --without-php \
+ --without-php_extension \
+ --without-dart \
+ --without-erlang \
+ --without-go \
+ --without-d \
+ --without-nodejs \
+ --without-nodets \
+ --without-lua \
+ --without-rs \
+ --without-swift
+
+ - name: Run configure 3.x
+ if: matrix.python-version == '3.x'
+ run: |
+ ./configure \
+ --disable-debug \
+ --disable-tests \
+ --disable-dependency-tracking \
+ --without-cpp \
+ --without-c_glib \
+ --without-java \
+ --without-kotlin \
+ --without-python \
+ --with-py3 \
+ --without-ruby \
+ --without-haxe \
+ --without-netstd \
+ --without-perl \
+ --without-php \
+ --without-php_extension \
+ --without-dart \
+ --without-erlang \
+ --without-go \
+ --without-d \
+ --without-nodejs \
+ --without-nodets \
+ --without-lua \
+ --without-rs \
+ --without-swift
+
+ - uses: actions/download-artifact@v3
+ with:
+ name: thrift-compiler
+ path: compiler/cpp
+
+ - name: Run thrift-compiler
+ run: |
+ chmod a+x compiler/cpp/thrift
+ compiler/cpp/thrift -version
+
+ - name: Run make python
+ run: make -C lib/py
Review Comment:
does this run the unit tests or does it only make sure that the code builds?
##########
.github/workflows/build.yml:
##########
@@ -128,3 +128,171 @@ jobs:
- name: Run make kotlin
run: make -C lib/kotlin
+
+ lib-rust:
Review Comment:
this seems unrelated to what the pr title/description says it does? but since the jira ticket itself covers all languages I don't really see this as a problem :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jimexist commented on pull request #2596: THRIFT-5564: add GitHub action for python 2.x and 3.x
Posted by GitBox <gi...@apache.org>.
Jimexist commented on PR #2596:
URL: https://github.com/apache/thrift/pull/2596#issuecomment-1119711296
before merging
- #2588
@fishy do you want to have a look at this? this _might_ help my work on #2588 as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jimexist closed pull request #2596: THRIFT-5564: add GitHub action for python 2.x and 3.x
Posted by "Jimexist (via GitHub)" <gi...@apache.org>.
Jimexist closed pull request #2596: THRIFT-5564: add GitHub action for python 2.x and 3.x
URL: https://github.com/apache/thrift/pull/2596
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org