You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Martijn van Groningen (JIRA)" <ji...@apache.org> on 2011/06/14 22:46:48 UTC
[jira] [Created] (SOLR-2591) Remove commitLockTimeout option from
solrconfig.xml
Remove commitLockTimeout option from solrconfig.xml
---------------------------------------------------
Key: SOLR-2591
URL: https://issues.apache.org/jira/browse/SOLR-2591
Project: Solr
Issue Type: Improvement
Reporter: Martijn van Groningen
Assignee: Martijn van Groningen
Priority: Minor
Fix For: 4.0
I've noticed that commitLockTimeout option is loaded by the configuration but no longer used. This issue will be concerned with removing this option from all solrconfig.xml files (including example) and from the SolrConfig class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-2591) Remove commitLockTimeout option from
solrconfig.xml
Posted by "Martijn van Groningen (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141987#comment-13141987 ]
Martijn van Groningen commented on SOLR-2591:
---------------------------------------------
Looks great Luca! This should be committed soon.
> Remove commitLockTimeout option from solrconfig.xml
> ---------------------------------------------------
>
> Key: SOLR-2591
> URL: https://issues.apache.org/jira/browse/SOLR-2591
> Project: Solr
> Issue Type: Improvement
> Reporter: Martijn van Groningen
> Assignee: Martijn van Groningen
> Priority: Minor
> Fix For: 3.5, 4.0
>
> Attachments: SOLR-2591.patch
>
>
> I've noticed that commitLockTimeout option is loaded by the configuration but no longer used. This issue will be concerned with removing this option from all solrconfig.xml files (including example) and from the SolrConfig class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Issue Comment Edited] (SOLR-2591) Remove commitLockTimeout
option from solrconfig.xml
Posted by "Luca Cavanna (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141203#comment-13141203 ]
Luca Cavanna edited comment on SOLR-2591 at 11/1/11 2:32 PM:
-------------------------------------------------------------
I think this unused option can be misleading, so why not remove it?
I attached a patch for the trunk. I also found out some double use of the same value for writeLockTimeout in configuration files (inside indexDefaults): I could be wrong but I don't think the repetition is useful, so I've fixed it. Please let me know whether the patch looks good or not.
was (Author: lucacavanna):
I think this unused option can be misleading, so why not remove it?
I attached a patch for the trunk. I also found out some double use of the same value for writeLockTimeout in configuration files (inside indexDefaults): I could be wrong but I don't the repetition is useful, so I've fixed it. Please let me know whether the patch looks good or not.
> Remove commitLockTimeout option from solrconfig.xml
> ---------------------------------------------------
>
> Key: SOLR-2591
> URL: https://issues.apache.org/jira/browse/SOLR-2591
> Project: Solr
> Issue Type: Improvement
> Reporter: Martijn van Groningen
> Assignee: Martijn van Groningen
> Priority: Minor
> Fix For: 4.0
>
> Attachments: SOLR-2591.patch
>
>
> I've noticed that commitLockTimeout option is loaded by the configuration but no longer used. This issue will be concerned with removing this option from all solrconfig.xml files (including example) and from the SolrConfig class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-2591) Remove commitLockTimeout option from
solrconfig.xml
Posted by "Luca Cavanna (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Luca Cavanna updated SOLR-2591:
-------------------------------
Attachment: SOLR-2591.patch
I think this unused option can be misleading, so why not remove it?
I attached a patch for the trunk. I also found out some double use of the same value for writeLockTimeout in configuration files (inside indexDefaults): I could be wrong but I don't the repetition is useful, so I've fixed it. Please let me know whether the patch looks good or not.
> Remove commitLockTimeout option from solrconfig.xml
> ---------------------------------------------------
>
> Key: SOLR-2591
> URL: https://issues.apache.org/jira/browse/SOLR-2591
> Project: Solr
> Issue Type: Improvement
> Reporter: Martijn van Groningen
> Assignee: Martijn van Groningen
> Priority: Minor
> Fix For: 4.0
>
> Attachments: SOLR-2591.patch
>
>
> I've noticed that commitLockTimeout option is loaded by the configuration but no longer used. This issue will be concerned with removing this option from all solrconfig.xml files (including example) and from the SolrConfig class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (SOLR-2591) Remove commitLockTimeout option from
solrconfig.xml
Posted by "Martijn van Groningen (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martijn van Groningen resolved SOLR-2591.
-----------------------------------------
Resolution: Fixed
Committed to trunk and 3x branch.
> Remove commitLockTimeout option from solrconfig.xml
> ---------------------------------------------------
>
> Key: SOLR-2591
> URL: https://issues.apache.org/jira/browse/SOLR-2591
> Project: Solr
> Issue Type: Improvement
> Reporter: Martijn van Groningen
> Assignee: Martijn van Groningen
> Priority: Minor
> Fix For: 3.5, 4.0
>
> Attachments: SOLR-2591.patch
>
>
> I've noticed that commitLockTimeout option is loaded by the configuration but no longer used. This issue will be concerned with removing this option from all solrconfig.xml files (including example) and from the SolrConfig class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-2591) Remove commitLockTimeout option from
solrconfig.xml
Posted by "Martijn van Groningen (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martijn van Groningen updated SOLR-2591:
----------------------------------------
Fix Version/s: 3.5
> Remove commitLockTimeout option from solrconfig.xml
> ---------------------------------------------------
>
> Key: SOLR-2591
> URL: https://issues.apache.org/jira/browse/SOLR-2591
> Project: Solr
> Issue Type: Improvement
> Reporter: Martijn van Groningen
> Assignee: Martijn van Groningen
> Priority: Minor
> Fix For: 3.5, 4.0
>
> Attachments: SOLR-2591.patch
>
>
> I've noticed that commitLockTimeout option is loaded by the configuration but no longer used. This issue will be concerned with removing this option from all solrconfig.xml files (including example) and from the SolrConfig class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-2591) Remove commitLockTimeout option from
solrconfig.xml
Posted by "Chris Male (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141989#comment-13141989 ]
Chris Male commented on SOLR-2591:
----------------------------------
+1
> Remove commitLockTimeout option from solrconfig.xml
> ---------------------------------------------------
>
> Key: SOLR-2591
> URL: https://issues.apache.org/jira/browse/SOLR-2591
> Project: Solr
> Issue Type: Improvement
> Reporter: Martijn van Groningen
> Assignee: Martijn van Groningen
> Priority: Minor
> Fix For: 3.5, 4.0
>
> Attachments: SOLR-2591.patch
>
>
> I've noticed that commitLockTimeout option is loaded by the configuration but no longer used. This issue will be concerned with removing this option from all solrconfig.xml files (including example) and from the SolrConfig class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org