You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zhangminglei <gi...@git.apache.org> on 2017/11/04 11:00:41 UTC
[GitHub] flink pull request #4946: [FLINK-7967] [config] Deprecate Hadoop specific Fl...
GitHub user zhangminglei opened a pull request:
https://github.com/apache/flink/pull/4946
[FLINK-7967] [config] Deprecate Hadoop specific Flink configuration o…
## What is the purpose of the change
This PR is mainly for deprecated hadoop specific Flink configuration options. We hope people use environment variable HADOOP_CONF_DIR as a replacement.
## Brief change log
- Add a warning message to hadoop configuration in ```flink-conf.yaml``` file.
- Add @Deprecated annotation to ```HDFS_DEFAULT_CONFIG```, ```HDFS_SITE_CONFIG```, ```PATH_HADOOP_CONFIG``` three fields which in ```ConfigConstants.java```.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (JavaDocs)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhangminglei/flink flink-7967
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4946.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4946
----
commit 51ab28ffc6282a4df7e0b47fad260e00ddc5781e
Author: zhangminglei <zm...@163.com>
Date: 2017-11-04T10:41:25Z
[FLINK-7967] [config] Deprecate Hadoop specific Flink configuration options
----
---
[GitHub] flink pull request #4946: [FLINK-7967] [config] Deprecate Hadoop specific Fl...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4946
---
[GitHub] flink issue #4946: [FLINK-7967] [config] Deprecate Hadoop specific Flink con...
Posted by zhangminglei <gi...@git.apache.org>.
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/4946
Hello, @greghogan I have updated the code, Could you take a look when you are free ? Thanks.
---
[GitHub] flink pull request #4946: [FLINK-7967] [config] Deprecate Hadoop specific Fl...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/4946#discussion_r152405696
--- Diff: flink-dist/src/main/resources/flink-conf.yaml ---
@@ -151,6 +151,9 @@ jobmanager.web.port: 8081
# Path to the Hadoop configuration directory.
#
+# Warning: these keys are deprecated and will be removed in 1.5. Instead, use
--- End diff --
I see your question on a specific future version for removing these keys was not answered but I expect that it won't be for 1.5 if ever. I think we can leave this at the deprecation notice and recommendation to use `HADOOP_CONF_DIR` without stating a time for removal.
---
[GitHub] flink issue #4946: [FLINK-7967] [config] Deprecate Hadoop specific Flink con...
Posted by zhangminglei <gi...@git.apache.org>.
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/4946
Thanks, @greghogan . I will make a first refinement based on your suggestions.
---