You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "pratyush-prateek (via GitHub)" <gi...@apache.org> on 2024/02/09 06:09:51 UTC

Re: [PR] [SPARK-35303][PYTHON] Enable pinned thread mode by default [spark]

pratyush-prateek commented on PR #32429:
URL: https://github.com/apache/spark/pull/32429#issuecomment-1935386241

   @HyukjinKwon So pinned thread mode is enabled by default in spark 3.2.0 onwards? The only thing users need to do if they need to spawn threads, is use `InheritableThread` API, can we say that? 
   
   > Okay, if the users are using a `ThreadPool`, they won't get affected a lot by this change since the threads are reused. With this change, it could only affect the users who lunches Spark jobs in a plain thread a lot, which is discouraged in practice anyway.
   > 
   > Let me merge this and try it out. The change here is correct in principle.
   
   Also, how using a `ThreadPool` wont' affect? I am guessing you are talking about `multiprocessing.pool.Threadpool` module. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org