You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/06/06 21:28:45 UTC
[GitHub] [incubator-superset] etr2460 opened a new issue #10004: [TRACKER] Migrate JavaScript files to TypeScript
etr2460 opened a new issue #10004:
URL: https://github.com/apache/incubator-superset/issues/10004
This issue tracks Superset's migration from JavaScript to TypeScript (as started in [SIP-36](https://github.com/apache/incubator-superset/issues/9101)). If you'd like to help with the migration, feel free to take an unchecked directory and convert the files within the immediate directory from JavaScript/JSX to TypeScript/TSX. #9162 and #9180 provide some tips for performing the migration. Once completed and PR'ed out, feel free to tag myself (@etr2460) or anyone else in the file's git-blame for review.
We really appreciate any work done here, and are happy to help resolve any issues you may come across!
## Tracker
- [x] `src`
- [ ] `src/CRUD`
- [ ] `src/SqlLab`
- [ ] `src/SqlLab/actions`
- [ ] `src/SqlLab/components`
- [ ] `src/SqlLab/reducers`
- [ ] `src/SqlLab/utils`
- [ ] `src/addSlice`
- [ ] `src/chart`
- [ ] `src/components`
- [x] `src/components/ErrorMessage`
- [ ] `src/components/FilterableTable`
- [x] `src/components/ListView`
- [ ] `src/components/Menu`
- [ ] `src/components/Select`
- [x] `src/components/Select/WindowedSelect`
- [ ] `src/dashboard`
- [ ] `src/dashboard/actions`
- [ ] `src/dashboard/components`
- [ ] `src/dashboard/components/dnd`
- [ ] `src/dashboard/components/filterscope`
- [ ] `src/dashboard/components/gridComponents`
- [ ] `src/dashboard/components/gridComponents/new`
- [ ] `src/dashboard/components/menu`
- [ ] `src/dashboard/components/resizable`
- [ ] `src/dashboard/containers`
- [ ] `src/dashboard/fixtures`
- [ ] `src/dashboard/reducers`
- [ ] `src/dashboard/util`
- [ ] `src/dashboard/util/charts`
- [ ] `src/dashboard/util/logging`
- [ ] `src/datasource`
- [ ] `src/explore`
- [ ] `src/explore/actions`
- [ ] `src/explore/components`
- [ ] `src/explore/components/controls`
- [ ] `src/explore/controlPanels`
- [ ] `src/explore/propTypes`
- [ ] `src/explore/reducers`
- [ ] `src/logger`
- [ ] `src/logger/actions`
- [ ] `src/messageToasts`
- [ ] `src/messageToasts/actions`
- [ ] `src/messageToasts/components`
- [ ] `src/messageToasts/containers`
- [x] `src/messageToasts/enhancers`
- [ ] `src/messageToasts/reducers`
- [ ] `src/messageToasts/utils`
- [ ] `src/middleware`
- [ ] `src/modules`
- [ ] `src/profile`
- [ ] `src/profile/components`
- [ ] `src/setup`
- [ ] `src/showSavedQuery`
- [x] `src/types`
- [ ] `src/utils`
- [x] `src/views/chartList`
- [x] `src/views/dashboardList`
- [x] `src/views/datasetList`
- [ ] `src/visualizations`
- [ ] `src/visualizations/FilterBox`
- [ ] `src/visualizations/TimeTable`
- [ ] `src/visualizations/presets`
- [ ] `src/welcome`
- [ ] `spec/__mocks__`
- [ ] `spec/fixtures`
- [ ] `spec/helpers`
- [ ] `spec/javascripts/CRUD`
- [ ] `spec/javascripts/addSlice`
- [ ] `spec/javascripts/chart`
- [ ] `spec/javascripts/components`
- [x] `spec/javascripts/components/ErrorMessage`
- [ ] `spec/javascripts/components/FilterableTable`
- [ ] `spec/javascripts/components/ListView`
- [ ] `spec/javascripts/dashboard/actions`
- [ ] `spec/javascripts/dashboard/components`
- [ ] `spec/javascripts/dashboard/components/dnd`
- [ ] `spec/javascripts/dashboard/components/gridComponents`
- [ ] `spec/javascripts/dashboard/components/gridComponents/new`
- [ ] `spec/javascripts/dashboard/components/menu`
- [ ] `spec/javascripts/dashboard/components/resizable`
- [ ] `spec/javascripts/dashboard/fixtures`
- [ ] `spec/javascripts/dashboard/helpers`
- [ ] `spec/javascripts/dashboard/reducers`
- [ ] `spec/javascripts/dashboard/util`
- [ ] `spec/javascripts/datasource`
- [ ] `spec/javascripts/explore`
- [ ] `spec/javascripts/explore/components`
- [ ] `spec/javascripts/messageToasts`
- [ ] `spec/javascripts/messageToasts/components`
- [ ] `spec/javascripts/messageToasts/reducers`
- [ ] `spec/javascripts/messageToasts/utils`
- [ ] `spec/javascripts/middleware`
- [ ] `spec/javascripts/modules`
- [ ] `spec/javascripts/profile`
- [ ] `spec/javascripts/showSavedQuery`
- [ ] `spec/javascripts/sqllab`
- [ ] `spec/javascripts/sqllab/actions`
- [ ] `spec/javascripts/sqllab/reducers`
- [ ] `spec/javascripts/sqllab/utils`
- [ ] `spec/javascripts/utils`
- [ ] `spec/javascripts/views/chartList`
- [ ] `spec/javascripts/views/dashboardList`
- [ ] `spec/javascripts/views/datasetList`
- [ ] `spec/javascripts/welcome`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] tanmaylaud commented on issue #10004: [TRACKER] Migrate JavaScript files to TypeScript
Posted by GitBox <gi...@apache.org>.
tanmaylaud commented on issue #10004:
URL: https://github.com/apache/incubator-superset/issues/10004#issuecomment-664101045
@etr2460 I propose adding more requirement here: Changing the class components to functional components and using react hooks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #10004: [TRACKER] Migrate JavaScript files to TypeScript
Posted by GitBox <gi...@apache.org>.
issue-label-bot[bot] commented on issue #10004:
URL: https://github.com/apache/incubator-superset/issues/10004#issuecomment-640120433
Issue-Label Bot is automatically applying the label `#enhancement` to this issue, with a confidence of 0.87. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!
Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] tanmaylaud edited a comment on issue #10004: [TRACKER] Migrate JavaScript files to TypeScript
Posted by GitBox <gi...@apache.org>.
tanmaylaud edited a comment on issue #10004:
URL: https://github.com/apache/incubator-superset/issues/10004#issuecomment-664101045
@etr2460 I propose adding one more requirement here: Changing the class components to functional components and using react hooks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] tanmaylaud commented on issue #10004: [TRACKER] Migrate JavaScript files to TypeScript
Posted by GitBox <gi...@apache.org>.
tanmaylaud commented on issue #10004:
URL: https://github.com/apache/incubator-superset/issues/10004#issuecomment-663868685
@etr2460 I noticed issues in src/components/ListView/Filters.tsx (introduced by tsx migration) in PaginatedSelectComponent. Can you please confirm if it requires a fix?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org