[GitHub] [flink-kubernetes-operator] gyfora commented on a change in pull request #65: [FLINK-26649] Add startTime in JobStatus

[GitBox <gi...@apache.org>]

gyfora commented on a change in pull request #65:
URL: https://github.com/apache/flink-kubernetes-operator/pull/65#discussion_r827687270



##########
File path: flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/JobObserver.java
##########
@@ -87,8 +87,8 @@ private void updateJobStatus(JobStatus status, List<JobStatusMessage> clusterJob
         status.setState(newJob.getJobState().name());
         status.setJobName(newJob.getJobName());
         status.setJobId(newJob.getJobId().toHexString());
-        // track the start time, changing timestamp would cause busy reconciliation
-        status.setUpdateTime(String.valueOf(newJob.getStartTime()));
+        status.setStartTime(String.valueOf(newJob.getStartTime()));
+        status.setUpdateTime(String.valueOf(System.currentTimeMillis()));

Review comment:
       @wangyang0918 exactly, we only want to trigger new reconcile automatically when the Spec itself is changed by the user. This does not affect reconciliations that we schedule ourselves but avoids immediate reconciliation triggers when the status changes.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org