You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by GitBox <gi...@apache.org> on 2022/06/17 10:22:42 UTC
[GitHub] [incubator-pegasus] foreverneverer opened a new pull request, #1008: feat(dup_enhancement#27): update dulication command in admin-cli
foreverneverer opened a new pull request, #1008:
URL: https://github.com/apache/incubator-pegasus/pull/1008
# Ref-Issue
https://github.com/apache/incubator-pegasus/issues/892
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] foreverneverer commented on a diff in pull request #1008: feat(dup_enhancement#27): update dulication command in admin-cli
Posted by GitBox <gi...@apache.org>.
foreverneverer commented on code in PR #1008:
URL: https://github.com/apache/incubator-pegasus/pull/1008#discussion_r901220187
##########
admin-cli/cmd/duplication.go:
##########
@@ -49,11 +49,11 @@ func init() {
if c.Flags.String("cluster") == "" {
return fmt.Errorf("cluster cannot be empty")
}
- return executor.AddDuplication(pegasusClient, c.UseTable, c.Flags.String("cluster"), c.Flags.Bool("freezed"))
+ return executor.AddDuplication(pegasusClient, c.UseTable, c.Flags.String("cluster"), c.Flags.Bool("sst"))
Review Comment:
duplication v2 has removed `freezed`, and add `whether duplicate checkpoint`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] foreverneverer merged pull request #1008: feat(dup_enhancement#27): update dulication command in admin-cli
Posted by GitBox <gi...@apache.org>.
foreverneverer merged PR #1008:
URL: https://github.com/apache/incubator-pegasus/pull/1008
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] foreverneverer commented on a diff in pull request #1008: feat(dup_enhancement#27): update dulication command in admin-cli
Posted by GitBox <gi...@apache.org>.
foreverneverer commented on code in PR #1008:
URL: https://github.com/apache/incubator-pegasus/pull/1008#discussion_r901220187
##########
admin-cli/cmd/duplication.go:
##########
@@ -49,11 +49,11 @@ func init() {
if c.Flags.String("cluster") == "" {
return fmt.Errorf("cluster cannot be empty")
}
- return executor.AddDuplication(pegasusClient, c.UseTable, c.Flags.String("cluster"), c.Flags.Bool("freezed"))
+ return executor.AddDuplication(pegasusClient, c.UseTable, c.Flags.String("cluster"), c.Flags.Bool("sst"))
Review Comment:
command args should be as short as possible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on a diff in pull request #1008: feat(dup_enhancement#27): update dulication command in admin-cli
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on code in PR #1008:
URL: https://github.com/apache/incubator-pegasus/pull/1008#discussion_r901210173
##########
admin-cli/cmd/duplication.go:
##########
@@ -49,11 +49,11 @@ func init() {
if c.Flags.String("cluster") == "" {
return fmt.Errorf("cluster cannot be empty")
}
- return executor.AddDuplication(pegasusClient, c.UseTable, c.Flags.String("cluster"), c.Flags.Bool("freezed"))
+ return executor.AddDuplication(pegasusClient, c.UseTable, c.Flags.String("cluster"), c.Flags.Bool("sst"))
Review Comment:
why not naming `duplicateCheckpoint`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org