You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2019/01/29 16:24:52 UTC
Re: Review Request 69818: Added offer filters resources to static
framework configuration.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69818/
-----------------------------------------------------------
(Updated Jan. 29, 2019, 5:24 p.m.)
Review request for mesos, Benjamin Mahler and Meng Zhu.
Summary (updated)
-----------------
Added offer filters resources to static framework configuration.
Bugs: MESOS-9523
https://issues.apache.org/jira/browse/MESOS-9523
Repository: mesos
Description (updated)
-------
This patch adds new fields to `FrameworkInfo` which can be used by
frameworks to configure static, per-role resource requirements. We
currently support specifying minimal allocatable resources which can
e.g., be interpreted by allocators to filter out resources not relevant
to frameworks, or make allocations below globally configured minimal
allocatable resources for particular frameworks.
Diffs (updated)
-----
include/mesos/mesos.proto 3477b7db4dc64187aa55e8e4feb66a62f7951429
include/mesos/v1/mesos.proto 692940bc862e61b9899aa159f29b662f3aade033
src/common/resource_quantities.hpp 11eb426104577bbbbb7977c2307df3e4917085cd
src/common/resource_quantities.cpp 320983929cd7d14973c4b98d6ed5338de690ff5f
Diff: https://reviews.apache.org/r/69818/diff/3/
Changes: https://reviews.apache.org/r/69818/diff/2-3/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 69818: Added offer filters to static framework
configuration.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69818/#review212841
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Mahler
On Feb. 14, 2019, 8:45 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69818/
> -----------------------------------------------------------
>
> (Updated Feb. 14, 2019, 8:45 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Meng Zhu.
>
>
> Bugs: MESOS-9523
> https://issues.apache.org/jira/browse/MESOS-9523
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds a new field to `FrameworkInfo` which can be used by
> frameworks to configure static, per-role resource requirements. We
> currently support specifying minimal allocatable resources which is
> interpreted by the default, hierarchical allocator for filtering out
> resources not relevant to the framework, and for overriding any globally
> configured `min_allocatable_resources` on a per framework, per role
> basis.
>
> We use a new message `ResourceQuantities` to specify resource
> requirements. This class is modelled after the internal class of the
> same name, and we provide a conversion from the API to the internal
> type.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 9d5c2b53164adb44eb4a6f12a507e009bd607940
> include/mesos/v1/mesos.proto aef31eb5b8781182d3f42d935b12470b319027ed
> src/common/resource_quantities.hpp 11eb426104577bbbbb7977c2307df3e4917085cd
> src/common/resource_quantities.cpp 320983929cd7d14973c4b98d6ed5338de690ff5f
> src/master/framework.cpp 4089cf4dfc65ac4dc5a092c04f4c2022ed8a1587
>
>
> Diff: https://reviews.apache.org/r/69818/diff/11/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 69818: Added offer filters to static framework
configuration.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69818/
-----------------------------------------------------------
(Updated Feb. 14, 2019, 9:45 p.m.)
Review request for mesos, Benjamin Mahler and Meng Zhu.
Changes
-------
Update documentation
Bugs: MESOS-9523
https://issues.apache.org/jira/browse/MESOS-9523
Repository: mesos
Description
-------
This patch adds a new field to `FrameworkInfo` which can be used by
frameworks to configure static, per-role resource requirements. We
currently support specifying minimal allocatable resources which is
interpreted by the default, hierarchical allocator for filtering out
resources not relevant to the framework, and for overriding any globally
configured `min_allocatable_resources` on a per framework, per role
basis.
We use a new message `ResourceQuantities` to specify resource
requirements. This class is modelled after the internal class of the
same name, and we provide a conversion from the API to the internal
type.
Diffs (updated)
-----
include/mesos/mesos.proto 9d5c2b53164adb44eb4a6f12a507e009bd607940
include/mesos/v1/mesos.proto aef31eb5b8781182d3f42d935b12470b319027ed
src/common/resource_quantities.hpp 11eb426104577bbbbb7977c2307df3e4917085cd
src/common/resource_quantities.cpp 320983929cd7d14973c4b98d6ed5338de690ff5f
src/master/framework.cpp 4089cf4dfc65ac4dc5a092c04f4c2022ed8a1587
Diff: https://reviews.apache.org/r/69818/diff/11/
Changes: https://reviews.apache.org/r/69818/diff/10-11/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 69818: Added offer filters to static framework
configuration.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69818/
-----------------------------------------------------------
(Updated Feb. 11, 2019, 5:19 p.m.)
Review request for mesos, Benjamin Mahler and Meng Zhu.
Changes
-------
Add an example quantity as suggested offline by jdef
Bugs: MESOS-9523
https://issues.apache.org/jira/browse/MESOS-9523
Repository: mesos
Description
-------
This patch adds a new field to `FrameworkInfo` which can be used by
frameworks to configure static, per-role resource requirements. We
currently support specifying minimal allocatable resources which is
interpreted by the default, hierarchical allocator for filtering out
resources not relevant to the framework, and for overriding any globally
configured `min_allocatable_resources` on a per framework, per role
basis.
We use a new message `ResourceQuantities` to specify resource
requirements. This class is modelled after the internal class of the
same name, and we provide a conversion from the API to the internal
type.
Diffs (updated)
-----
include/mesos/mesos.proto 9d5c2b53164adb44eb4a6f12a507e009bd607940
include/mesos/v1/mesos.proto aef31eb5b8781182d3f42d935b12470b319027ed
src/common/resource_quantities.hpp 11eb426104577bbbbb7977c2307df3e4917085cd
src/common/resource_quantities.cpp 320983929cd7d14973c4b98d6ed5338de690ff5f
src/master/framework.cpp 4089cf4dfc65ac4dc5a092c04f4c2022ed8a1587
Diff: https://reviews.apache.org/r/69818/diff/10/
Changes: https://reviews.apache.org/r/69818/diff/9-10/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 69818: Added offer filters to static framework
configuration.
Posted by Benjamin Bannier <be...@mesosphere.io>.
> On Feb. 6, 2019, 6:01 p.m., James DeFelice wrote:
> > include/mesos/mesos.proto
> > Lines 1541 (patched)
> > <https://reviews.apache.org/r/69818/diff/8/?file=2123848#file2123848line1541>
> >
> > Each `ResourceQuantities` item here represents a "shape" that will be matched against a potential offer, yes?
>
> Benjamin Bannier wrote:
> Yes. Anything you feel is missing currently?
I added an example use.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69818/#review212609
-----------------------------------------------------------
On Feb. 11, 2019, 5:19 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69818/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2019, 5:19 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Meng Zhu.
>
>
> Bugs: MESOS-9523
> https://issues.apache.org/jira/browse/MESOS-9523
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds a new field to `FrameworkInfo` which can be used by
> frameworks to configure static, per-role resource requirements. We
> currently support specifying minimal allocatable resources which is
> interpreted by the default, hierarchical allocator for filtering out
> resources not relevant to the framework, and for overriding any globally
> configured `min_allocatable_resources` on a per framework, per role
> basis.
>
> We use a new message `ResourceQuantities` to specify resource
> requirements. This class is modelled after the internal class of the
> same name, and we provide a conversion from the API to the internal
> type.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 9d5c2b53164adb44eb4a6f12a507e009bd607940
> include/mesos/v1/mesos.proto aef31eb5b8781182d3f42d935b12470b319027ed
> src/common/resource_quantities.hpp 11eb426104577bbbbb7977c2307df3e4917085cd
> src/common/resource_quantities.cpp 320983929cd7d14973c4b98d6ed5338de690ff5f
> src/master/framework.cpp 4089cf4dfc65ac4dc5a092c04f4c2022ed8a1587
>
>
> Diff: https://reviews.apache.org/r/69818/diff/10/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 69818: Added offer filters to static framework
configuration.
Posted by Benjamin Bannier <be...@mesosphere.io>.
> On Feb. 6, 2019, 6:01 p.m., James DeFelice wrote:
> > include/mesos/mesos.proto
> > Lines 1541 (patched)
> > <https://reviews.apache.org/r/69818/diff/8/?file=2123848#file2123848line1541>
> >
> > Each `ResourceQuantities` item here represents a "shape" that will be matched against a potential offer, yes?
Yes. Anything you feel is missing currently?
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69818/#review212609
-----------------------------------------------------------
On Feb. 4, 2019, 9:37 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69818/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2019, 9:37 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Meng Zhu.
>
>
> Bugs: MESOS-9523
> https://issues.apache.org/jira/browse/MESOS-9523
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds a new field to `FrameworkInfo` which can be used by
> frameworks to configure static, per-role resource requirements. We
> currently support specifying minimal allocatable resources which is
> interpreted by the default, hierarchical allocator for filtering out
> resources not relevant to the framework, and for overriding any globally
> configured `min_allocatable_resources` on a per framework, per role
> basis.
>
> We use a new message `ResourceQuantities` to specify resource
> requirements. This class is modelled after the internal class of the
> same name, and we provide a conversion from the API to the internal
> type.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 9d5c2b53164adb44eb4a6f12a507e009bd607940
> include/mesos/v1/mesos.proto aef31eb5b8781182d3f42d935b12470b319027ed
> src/common/resource_quantities.hpp 11eb426104577bbbbb7977c2307df3e4917085cd
> src/common/resource_quantities.cpp 320983929cd7d14973c4b98d6ed5338de690ff5f
> src/master/framework.cpp 4089cf4dfc65ac4dc5a092c04f4c2022ed8a1587
>
>
> Diff: https://reviews.apache.org/r/69818/diff/8/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 69818: Added offer filters to static framework
configuration.
Posted by James DeFelice <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69818/#review212609
-----------------------------------------------------------
include/mesos/mesos.proto
Lines 1541 (patched)
<https://reviews.apache.org/r/69818/#comment298435>
Each `ResourceQuantities` item here represents a "shape" that will be matched against a potential offer, yes?
- James DeFelice
On Feb. 4, 2019, 8:37 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69818/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2019, 8:37 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Meng Zhu.
>
>
> Bugs: MESOS-9523
> https://issues.apache.org/jira/browse/MESOS-9523
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds a new field to `FrameworkInfo` which can be used by
> frameworks to configure static, per-role resource requirements. We
> currently support specifying minimal allocatable resources which is
> interpreted by the default, hierarchical allocator for filtering out
> resources not relevant to the framework, and for overriding any globally
> configured `min_allocatable_resources` on a per framework, per role
> basis.
>
> We use a new message `ResourceQuantities` to specify resource
> requirements. This class is modelled after the internal class of the
> same name, and we provide a conversion from the API to the internal
> type.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 9d5c2b53164adb44eb4a6f12a507e009bd607940
> include/mesos/v1/mesos.proto aef31eb5b8781182d3f42d935b12470b319027ed
> src/common/resource_quantities.hpp 11eb426104577bbbbb7977c2307df3e4917085cd
> src/common/resource_quantities.cpp 320983929cd7d14973c4b98d6ed5338de690ff5f
> src/master/framework.cpp 4089cf4dfc65ac4dc5a092c04f4c2022ed8a1587
>
>
> Diff: https://reviews.apache.org/r/69818/diff/8/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 69818: Added offer filters to static framework
configuration.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69818/
-----------------------------------------------------------
(Updated Feb. 4, 2019, 9:37 p.m.)
Review request for mesos, Benjamin Mahler and Meng Zhu.
Changes
-------
Move a comment from https://reviews.apache.org/r/69821/ here
Bugs: MESOS-9523
https://issues.apache.org/jira/browse/MESOS-9523
Repository: mesos
Description
-------
This patch adds a new field to `FrameworkInfo` which can be used by
frameworks to configure static, per-role resource requirements. We
currently support specifying minimal allocatable resources which is
interpreted by the default, hierarchical allocator for filtering out
resources not relevant to the framework, and for overriding any globally
configured `min_allocatable_resources` on a per framework, per role
basis.
We use a new message `ResourceQuantities` to specify resource
requirements. This class is modelled after the internal class of the
same name, and we provide a conversion from the API to the internal
type.
Diffs (updated)
-----
include/mesos/mesos.proto 9d5c2b53164adb44eb4a6f12a507e009bd607940
include/mesos/v1/mesos.proto aef31eb5b8781182d3f42d935b12470b319027ed
src/common/resource_quantities.hpp 11eb426104577bbbbb7977c2307df3e4917085cd
src/common/resource_quantities.cpp 320983929cd7d14973c4b98d6ed5338de690ff5f
src/master/framework.cpp 4089cf4dfc65ac4dc5a092c04f4c2022ed8a1587
Diff: https://reviews.apache.org/r/69818/diff/8/
Changes: https://reviews.apache.org/r/69818/diff/7-8/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 69818: Added offer filters to static framework
configuration.
Posted by Benjamin Bannier <be...@mesosphere.io>.
> On Feb. 4, 2019, 9:31 p.m., Benjamin Mahler wrote:
> > src/master/framework.cpp
> > Lines 504 (patched)
> > <https://reviews.apache.org/r/69818/diff/7/?file=2123816#file2123816line504>
> >
> > The comment you mentioned seems to be missing?
Accidentially squashed it into https://reviews.apache.org/r/69821/, fixed now.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69818/#review212522
-----------------------------------------------------------
On Feb. 4, 2019, 9:37 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69818/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2019, 9:37 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Meng Zhu.
>
>
> Bugs: MESOS-9523
> https://issues.apache.org/jira/browse/MESOS-9523
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds a new field to `FrameworkInfo` which can be used by
> frameworks to configure static, per-role resource requirements. We
> currently support specifying minimal allocatable resources which is
> interpreted by the default, hierarchical allocator for filtering out
> resources not relevant to the framework, and for overriding any globally
> configured `min_allocatable_resources` on a per framework, per role
> basis.
>
> We use a new message `ResourceQuantities` to specify resource
> requirements. This class is modelled after the internal class of the
> same name, and we provide a conversion from the API to the internal
> type.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 9d5c2b53164adb44eb4a6f12a507e009bd607940
> include/mesos/v1/mesos.proto aef31eb5b8781182d3f42d935b12470b319027ed
> src/common/resource_quantities.hpp 11eb426104577bbbbb7977c2307df3e4917085cd
> src/common/resource_quantities.cpp 320983929cd7d14973c4b98d6ed5338de690ff5f
> src/master/framework.cpp 4089cf4dfc65ac4dc5a092c04f4c2022ed8a1587
>
>
> Diff: https://reviews.apache.org/r/69818/diff/8/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 69818: Added offer filters to static framework
configuration.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69818/#review212522
-----------------------------------------------------------
Fix it, then Ship it!
src/master/framework.cpp
Lines 504 (patched)
<https://reviews.apache.org/r/69818/#comment298324>
The comment you mentioned seems to be missing?
- Benjamin Mahler
On Feb. 4, 2019, 11:14 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69818/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2019, 11:14 a.m.)
>
>
> Review request for mesos, Benjamin Mahler and Meng Zhu.
>
>
> Bugs: MESOS-9523
> https://issues.apache.org/jira/browse/MESOS-9523
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds a new field to `FrameworkInfo` which can be used by
> frameworks to configure static, per-role resource requirements. We
> currently support specifying minimal allocatable resources which is
> interpreted by the default, hierarchical allocator for filtering out
> resources not relevant to the framework, and for overriding any globally
> configured `min_allocatable_resources` on a per framework, per role
> basis.
>
> We use a new message `ResourceQuantities` to specify resource
> requirements. This class is modelled after the internal class of the
> same name, and we provide a conversion from the API to the internal
> type.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 9d5c2b53164adb44eb4a6f12a507e009bd607940
> include/mesos/v1/mesos.proto aef31eb5b8781182d3f42d935b12470b319027ed
> src/common/resource_quantities.hpp 11eb426104577bbbbb7977c2307df3e4917085cd
> src/common/resource_quantities.cpp 320983929cd7d14973c4b98d6ed5338de690ff5f
> src/master/framework.cpp 4089cf4dfc65ac4dc5a092c04f4c2022ed8a1587
>
>
> Diff: https://reviews.apache.org/r/69818/diff/7/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 69818: Added offer filters to static framework
configuration.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69818/
-----------------------------------------------------------
(Updated Feb. 4, 2019, 12:14 p.m.)
Review request for mesos, Benjamin Mahler and Meng Zhu.
Changes
-------
Mention behavior of default allocator in protos
Bugs: MESOS-9523
https://issues.apache.org/jira/browse/MESOS-9523
Repository: mesos
Description (updated)
-------
This patch adds a new field to `FrameworkInfo` which can be used by
frameworks to configure static, per-role resource requirements. We
currently support specifying minimal allocatable resources which is
interpreted by the default, hierarchical allocator for filtering out
resources not relevant to the framework, and for overriding any globally
configured `min_allocatable_resources` on a per framework, per role
basis.
We use a new message `ResourceQuantities` to specify resource
requirements. This class is modelled after the internal class of the
same name, and we provide a conversion from the API to the internal
type.
Diffs (updated)
-----
include/mesos/mesos.proto 9d5c2b53164adb44eb4a6f12a507e009bd607940
include/mesos/v1/mesos.proto aef31eb5b8781182d3f42d935b12470b319027ed
src/common/resource_quantities.hpp 11eb426104577bbbbb7977c2307df3e4917085cd
src/common/resource_quantities.cpp 320983929cd7d14973c4b98d6ed5338de690ff5f
src/master/framework.cpp 4089cf4dfc65ac4dc5a092c04f4c2022ed8a1587
Diff: https://reviews.apache.org/r/69818/diff/7/
Changes: https://reviews.apache.org/r/69818/diff/6-7/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 69818: Added offer filters to static framework
configuration.
Posted by Benjamin Bannier <be...@mesosphere.io>.
> On Jan. 31, 2019, 10 p.m., Benjamin Mahler wrote:
> > src/master/framework.cpp
> > Lines 504 (patched)
> > <https://reviews.apache.org/r/69818/diff/6/?file=2123539#file2123539line504>
> >
> > Can you guard this with a has check?
> >
> > As it stands it will produce a different message if newInfo has it unset (info will have it set vs newInfo has it not set)
This is a `map`, not an `optional` field. I added a comment as a hedge against confusion,
```
// We copy over the new (potentially empty) map of per-role filters.
```
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69818/#review212488
-----------------------------------------------------------
On Feb. 4, 2019, 12:14 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69818/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2019, 12:14 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Meng Zhu.
>
>
> Bugs: MESOS-9523
> https://issues.apache.org/jira/browse/MESOS-9523
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds a new field to `FrameworkInfo` which can be used by
> frameworks to configure static, per-role resource requirements. We
> currently support specifying minimal allocatable resources which is
> interpreted by the default, hierarchical allocator for filtering out
> resources not relevant to the framework, and for overriding any globally
> configured `min_allocatable_resources` on a per framework, per role
> basis.
>
> We use a new message `ResourceQuantities` to specify resource
> requirements. This class is modelled after the internal class of the
> same name, and we provide a conversion from the API to the internal
> type.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 9d5c2b53164adb44eb4a6f12a507e009bd607940
> include/mesos/v1/mesos.proto aef31eb5b8781182d3f42d935b12470b319027ed
> src/common/resource_quantities.hpp 11eb426104577bbbbb7977c2307df3e4917085cd
> src/common/resource_quantities.cpp 320983929cd7d14973c4b98d6ed5338de690ff5f
> src/master/framework.cpp 4089cf4dfc65ac4dc5a092c04f4c2022ed8a1587
>
>
> Diff: https://reviews.apache.org/r/69818/diff/7/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 69818: Added offer filters to static framework
configuration.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69818/#review212488
-----------------------------------------------------------
src/master/framework.cpp
Lines 504 (patched)
<https://reviews.apache.org/r/69818/#comment298248>
Can you guard this with a has check?
As it stands it will produce a different message if newInfo has it unset (info will have it set vs newInfo has it not set)
- Benjamin Mahler
On Jan. 31, 2019, 3:29 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69818/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2019, 3:29 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Meng Zhu.
>
>
> Bugs: MESOS-9523
> https://issues.apache.org/jira/browse/MESOS-9523
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds a new field to `FrameworkInfo` which can be used by
> frameworks to configure static, per-role resource requirements. We
> currently support specifying minimal allocatable resources which can
> e.g., be interpreted by allocators to filter out resources not relevant
> to frameworks, or make allocations below globally configured minimal
> allocatable resources for particular frameworks.
>
> We use a new message `ResourceQuantities` to specify resource
> requirements. This class is modelled after the internal class of the
> same name, and we provide a conversion from the API to the internal
> type.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 9d5c2b53164adb44eb4a6f12a507e009bd607940
> include/mesos/v1/mesos.proto aef31eb5b8781182d3f42d935b12470b319027ed
> src/common/resource_quantities.hpp 11eb426104577bbbbb7977c2307df3e4917085cd
> src/common/resource_quantities.cpp 320983929cd7d14973c4b98d6ed5338de690ff5f
> src/master/framework.cpp 4089cf4dfc65ac4dc5a092c04f4c2022ed8a1587
>
>
> Diff: https://reviews.apache.org/r/69818/diff/6/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 69818: Added offer filters to static framework
configuration.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69818/
-----------------------------------------------------------
(Updated Jan. 31, 2019, 4:29 p.m.)
Review request for mesos, Benjamin Mahler and Meng Zhu.
Bugs: MESOS-9523
https://issues.apache.org/jira/browse/MESOS-9523
Repository: mesos
Description
-------
This patch adds a new field to `FrameworkInfo` which can be used by
frameworks to configure static, per-role resource requirements. We
currently support specifying minimal allocatable resources which can
e.g., be interpreted by allocators to filter out resources not relevant
to frameworks, or make allocations below globally configured minimal
allocatable resources for particular frameworks.
We use a new message `ResourceQuantities` to specify resource
requirements. This class is modelled after the internal class of the
same name, and we provide a conversion from the API to the internal
type.
Diffs (updated)
-----
include/mesos/mesos.proto 9d5c2b53164adb44eb4a6f12a507e009bd607940
include/mesos/v1/mesos.proto aef31eb5b8781182d3f42d935b12470b319027ed
src/common/resource_quantities.hpp 11eb426104577bbbbb7977c2307df3e4917085cd
src/common/resource_quantities.cpp 320983929cd7d14973c4b98d6ed5338de690ff5f
src/master/framework.cpp 4089cf4dfc65ac4dc5a092c04f4c2022ed8a1587
Diff: https://reviews.apache.org/r/69818/diff/6/
Changes: https://reviews.apache.org/r/69818/diff/5-6/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 69818: Added offer filters to static framework
configuration.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69818/
-----------------------------------------------------------
(Updated Jan. 31, 2019, 4:15 p.m.)
Review request for mesos, Benjamin Mahler and Meng Zhu.
Changes
-------
Rebased.
Bugs: MESOS-9523
https://issues.apache.org/jira/browse/MESOS-9523
Repository: mesos
Description (updated)
-------
This patch adds a new field to `FrameworkInfo` which can be used by
frameworks to configure static, per-role resource requirements. We
currently support specifying minimal allocatable resources which can
e.g., be interpreted by allocators to filter out resources not relevant
to frameworks, or make allocations below globally configured minimal
allocatable resources for particular frameworks.
We use a new message `ResourceQuantities` to specify resource
requirements. This class is modelled after the internal class of the
same name, and we provide a conversion from the API to the internal
type.
Diffs (updated)
-----
include/mesos/mesos.proto 9d5c2b53164adb44eb4a6f12a507e009bd607940
include/mesos/v1/mesos.proto aef31eb5b8781182d3f42d935b12470b319027ed
src/common/resource_quantities.hpp 11eb426104577bbbbb7977c2307df3e4917085cd
src/common/resource_quantities.cpp 320983929cd7d14973c4b98d6ed5338de690ff5f
Diff: https://reviews.apache.org/r/69818/diff/5/
Changes: https://reviews.apache.org/r/69818/diff/4-5/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 69818: Added offer filters to static framework
configuration.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69818/
-----------------------------------------------------------
(Updated Jan. 30, 2019, 4:04 p.m.)
Review request for mesos, Benjamin Mahler and Meng Zhu.
Changes
-------
WIP.
Summary (updated)
-----------------
Added offer filters to static framework configuration.
Bugs: MESOS-9523
https://issues.apache.org/jira/browse/MESOS-9523
Repository: mesos
Description (updated)
-------
This patch adds a new field to `FrameworkInfo` which can be used by
frameworks to configure static, per-role resource requirements. We
currently support specifying minimal allocatable resources which can
e.g., be interpreted by allocators to filter out resources not relevant
to frameworks, or make allocations below globally configured minimal
allocatable resources for particular frameworks.
Diffs (updated)
-----
include/mesos/mesos.proto 3477b7db4dc64187aa55e8e4feb66a62f7951429
include/mesos/v1/mesos.proto 692940bc862e61b9899aa159f29b662f3aade033
src/common/resource_quantities.hpp 11eb426104577bbbbb7977c2307df3e4917085cd
src/common/resource_quantities.cpp 320983929cd7d14973c4b98d6ed5338de690ff5f
Diff: https://reviews.apache.org/r/69818/diff/4/
Changes: https://reviews.apache.org/r/69818/diff/3-4/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 69818: Added offer filters to static framework
configuration.
Posted by Benjamin Bannier <be...@mesosphere.io>.
> On Jan. 29, 2019, 9:14 p.m., Benjamin Mahler wrote:
> > src/common/resource_quantities.cpp
> > Lines 82-90 (patched)
> > <https://reviews.apache.org/r/69818/diff/3/?file=2123201#file2123201line82>
> >
> > Can we add some validation somewhere to ensure that negative value scalars are not provided?
https://reviews.apache.org/r/69862/
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69818/#review212419
-----------------------------------------------------------
On Jan. 30, 2019, 4:04 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69818/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2019, 4:04 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Meng Zhu.
>
>
> Bugs: MESOS-9523
> https://issues.apache.org/jira/browse/MESOS-9523
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds a new field to `FrameworkInfo` which can be used by
> frameworks to configure static, per-role resource requirements. We
> currently support specifying minimal allocatable resources which can
> e.g., be interpreted by allocators to filter out resources not relevant
> to frameworks, or make allocations below globally configured minimal
> allocatable resources for particular frameworks.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 3477b7db4dc64187aa55e8e4feb66a62f7951429
> include/mesos/v1/mesos.proto 692940bc862e61b9899aa159f29b662f3aade033
> src/common/resource_quantities.hpp 11eb426104577bbbbb7977c2307df3e4917085cd
> src/common/resource_quantities.cpp 320983929cd7d14973c4b98d6ed5338de690ff5f
>
>
> Diff: https://reviews.apache.org/r/69818/diff/4/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 69818: Added offer filters to static framework
configuration.
Posted by Benjamin Bannier <be...@mesosphere.io>.
> On Jan. 29, 2019, 9:14 p.m., Benjamin Mahler wrote:
> > I think you missed my top level comment from the last review to add context to the commit about the min allocatable flag and how this is providing a per-framework/role override of that global flag?
> >
> > Also, we're missing a patch for the master to allow changing the value upon framework re-registration?
>
> Benjamin Bannier wrote:
> Re:commit message, see my comment here, https://reviews.apache.org/r/69818/#comment298165.
>
> Re:changing the offer_filters, updated this patch.
Updated commit message.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69818/#review212419
-----------------------------------------------------------
On Feb. 4, 2019, 12:14 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69818/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2019, 12:14 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Meng Zhu.
>
>
> Bugs: MESOS-9523
> https://issues.apache.org/jira/browse/MESOS-9523
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds a new field to `FrameworkInfo` which can be used by
> frameworks to configure static, per-role resource requirements. We
> currently support specifying minimal allocatable resources which is
> interpreted by the default, hierarchical allocator for filtering out
> resources not relevant to the framework, and for overriding any globally
> configured `min_allocatable_resources` on a per framework, per role
> basis.
>
> We use a new message `ResourceQuantities` to specify resource
> requirements. This class is modelled after the internal class of the
> same name, and we provide a conversion from the API to the internal
> type.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 9d5c2b53164adb44eb4a6f12a507e009bd607940
> include/mesos/v1/mesos.proto aef31eb5b8781182d3f42d935b12470b319027ed
> src/common/resource_quantities.hpp 11eb426104577bbbbb7977c2307df3e4917085cd
> src/common/resource_quantities.cpp 320983929cd7d14973c4b98d6ed5338de690ff5f
> src/master/framework.cpp 4089cf4dfc65ac4dc5a092c04f4c2022ed8a1587
>
>
> Diff: https://reviews.apache.org/r/69818/diff/7/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 69818: Added offer filters to static framework
configuration.
Posted by Benjamin Bannier <be...@mesosphere.io>.
> On Jan. 29, 2019, 9:14 p.m., Benjamin Mahler wrote:
> > I think you missed my top level comment from the last review to add context to the commit about the min allocatable flag and how this is providing a per-framework/role override of that global flag?
> >
> > Also, we're missing a patch for the master to allow changing the value upon framework re-registration?
Re:commit message, see my comment here, https://reviews.apache.org/r/69818/#comment298165.
Re:changing the offer_filters, updated this patch.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69818/#review212419
-----------------------------------------------------------
On Jan. 31, 2019, 4:29 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69818/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2019, 4:29 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Meng Zhu.
>
>
> Bugs: MESOS-9523
> https://issues.apache.org/jira/browse/MESOS-9523
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds a new field to `FrameworkInfo` which can be used by
> frameworks to configure static, per-role resource requirements. We
> currently support specifying minimal allocatable resources which can
> e.g., be interpreted by allocators to filter out resources not relevant
> to frameworks, or make allocations below globally configured minimal
> allocatable resources for particular frameworks.
>
> We use a new message `ResourceQuantities` to specify resource
> requirements. This class is modelled after the internal class of the
> same name, and we provide a conversion from the API to the internal
> type.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 9d5c2b53164adb44eb4a6f12a507e009bd607940
> include/mesos/v1/mesos.proto aef31eb5b8781182d3f42d935b12470b319027ed
> src/common/resource_quantities.hpp 11eb426104577bbbbb7977c2307df3e4917085cd
> src/common/resource_quantities.cpp 320983929cd7d14973c4b98d6ed5338de690ff5f
> src/master/framework.cpp 4089cf4dfc65ac4dc5a092c04f4c2022ed8a1587
>
>
> Diff: https://reviews.apache.org/r/69818/diff/6/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 69818: Added offer filters resources to static
framework configuration.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69818/#review212419
-----------------------------------------------------------
I think you missed my top level comment from the last review to add context to the commit about the min allocatable flag and how this is providing a per-framework/role override of that global flag?
Also, we're missing a patch for the master to allow changing the value upon framework re-registration?
src/common/resource_quantities.cpp
Lines 82-90 (patched)
<https://reviews.apache.org/r/69818/#comment298185>
Can we add some validation somewhere to ensure that negative value scalars are not provided?
- Benjamin Mahler
On Jan. 29, 2019, 4:24 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69818/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2019, 4:24 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Meng Zhu.
>
>
> Bugs: MESOS-9523
> https://issues.apache.org/jira/browse/MESOS-9523
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds new fields to `FrameworkInfo` which can be used by
> frameworks to configure static, per-role resource requirements. We
> currently support specifying minimal allocatable resources which can
> e.g., be interpreted by allocators to filter out resources not relevant
> to frameworks, or make allocations below globally configured minimal
> allocatable resources for particular frameworks.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 3477b7db4dc64187aa55e8e4feb66a62f7951429
> include/mesos/v1/mesos.proto 692940bc862e61b9899aa159f29b662f3aade033
> src/common/resource_quantities.hpp 11eb426104577bbbbb7977c2307df3e4917085cd
> src/common/resource_quantities.cpp 320983929cd7d14973c4b98d6ed5338de690ff5f
>
>
> Diff: https://reviews.apache.org/r/69818/diff/3/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>