[GitHub] [superset] ra002890 commented on a change in pull request #18682: feat: It is possible to pass attributes to embedded iframe

[GitBox <gi...@apache.org>]

ra002890 commented on a change in pull request #18682:
URL: https://github.com/apache/superset/pull/18682#discussion_r808019660



##########
File path: superset-embedded-sdk/src/index.ts
##########
@@ -36,6 +36,8 @@ export type EmbedDashboardParams = {
   supersetDomain: string
   /** The html element within which to mount the iframe */
   mountPoint: HTMLElement
+  /** An id to identify the create iframe that will embed Superset */
+  iframeAttributes: Map<string, string> 

Review comment:
       From the first time I was trying to force only Iframe related attributes to be passed here, and I was not able to find a good way to do that, but with your suggestion I have found the Partial type and I could implement it. What do you think about my new implementation where only valid iframe attributes can be passed to it?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org