You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2020/05/18 20:51:00 UTC
[Impala-ASF-CR] IMPALA-9730: avoid TSAN data race in RuntimeFilterBank
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15944
Change subject: IMPALA-9730: avoid TSAN data race in RuntimeFilterBank
......................................................................
IMPALA-9730: avoid TSAN data race in RuntimeFilterBank
Testing:
Ran test_runtime_filters.py, checked ERROR output for data
race errors. There were none.
Change-Id: I5eb9da2208b5a1a70cbd85c060645979004c6220
---
M be/src/runtime/runtime-filter-bank.cc
M be/src/runtime/runtime-filter-bank.h
2 files changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/15944/1
--
To view, visit http://gerrit.cloudera.org:8080/15944
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5eb9da2208b5a1a70cbd85c060645979004c6220
Gerrit-Change-Number: 15944
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-9730: avoid TSAN data race in RuntimeFilterBank
Posted by "Sahil Takiar (Code Review)" <ge...@cloudera.org>.
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15944 )
Change subject: IMPALA-9730: avoid TSAN data race in RuntimeFilterBank
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15944
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5eb9da2208b5a1a70cbd85c060645979004c6220
Gerrit-Change-Number: 15944
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Mon, 18 May 2020 21:28:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9730: avoid TSAN data race in RuntimeFilterBank
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15944 )
Change subject: IMPALA-9730: avoid TSAN data race in RuntimeFilterBank
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5856/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/15944
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5eb9da2208b5a1a70cbd85c060645979004c6220
Gerrit-Change-Number: 15944
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Mon, 18 May 2020 21:24:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9730: avoid TSAN data race in RuntimeFilterBank
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15944 )
Change subject: IMPALA-9730: avoid TSAN data race in RuntimeFilterBank
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/15944
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5eb9da2208b5a1a70cbd85c060645979004c6220
Gerrit-Change-Number: 15944
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Tue, 19 May 2020 02:48:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9730: avoid TSAN data race in RuntimeFilterBank
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15944 )
Change subject: IMPALA-9730: avoid TSAN data race in RuntimeFilterBank
......................................................................
IMPALA-9730: avoid TSAN data race in RuntimeFilterBank
Testing:
Ran test_runtime_filters.py, checked ERROR output for data
race errors. There were none.
Change-Id: I5eb9da2208b5a1a70cbd85c060645979004c6220
Reviewed-on: http://gerrit.cloudera.org:8080/15944
Reviewed-by: Sahil Takiar <st...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/runtime/runtime-filter-bank.cc
M be/src/runtime/runtime-filter-bank.h
2 files changed, 4 insertions(+), 2 deletions(-)
Approvals:
Sahil Takiar: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/15944
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5eb9da2208b5a1a70cbd85c060645979004c6220
Gerrit-Change-Number: 15944
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-9730: avoid TSAN data race in RuntimeFilterBank
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15944 )
Change subject: IMPALA-9730: avoid TSAN data race in RuntimeFilterBank
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/6092/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/15944
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5eb9da2208b5a1a70cbd85c060645979004c6220
Gerrit-Change-Number: 15944
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Mon, 18 May 2020 21:45:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9730: avoid TSAN data race in RuntimeFilterBank
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has removed Sailesh Mukil from this change. ( http://gerrit.cloudera.org:8080/15944 )
Change subject: IMPALA-9730: avoid TSAN data race in RuntimeFilterBank
......................................................................
Removed reviewer Sailesh Mukil.
--
To view, visit http://gerrit.cloudera.org:8080/15944
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I5eb9da2208b5a1a70cbd85c060645979004c6220
Gerrit-Change-Number: 15944
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>