You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by thomas07vt <gi...@git.apache.org> on 2016/07/13 13:44:58 UTC
[GitHub] thrift pull request #1048: Ensuring that HTTP failures will clear the http t...
GitHub user thomas07vt opened a pull request:
https://github.com/apache/thrift/pull/1048
Ensuring that HTTP failures will clear the http transport outbuf var
With the current implementation, any Net HTTP failure will raise from the #flush() method without resetting the @outbuf variable.
I think that resetting the @outbuf on these failures is more "expected" behaviour. Especially if there is a malformed request that the downstream server does not want to/can't handle. As far as I can tell, there is not way to clear the @outbuf var apart from the #flush() method, so if that fails, then you will just keep appending requests to the out buffer.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/thomas07vt/thrift RubyLib-Reset_outbuf_on_http_failures
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1048.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1048
----
commit 01da6a5df2ac531a376b33f017f5b494e37152c5
Author: John Thomas <th...@vt.edu>
Date: 2016-07-12T15:06:19Z
Ensuring that HTTP failures will clear the http transport outbuf var
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request #1048: Ensuring that HTTP failures will clear the http t...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1048
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1048: Ensuring that HTTP failures will clear the http transpor...
Posted by thomas07vt <gi...@git.apache.org>.
Github user thomas07vt commented on the issue:
https://github.com/apache/thrift/pull/1048
@nsuke Just filed an issue:
https://issues.apache.org/jira/browse/THRIFT-3920
Please feel free to edit the issue(or tell me what should be edited) if I have left out any necessary info since this is the first time I have opened an issue on the Thrift Jira board.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1048: Ensuring that HTTP failures will clear the http transpor...
Posted by thomas07vt <gi...@git.apache.org>.
Github user thomas07vt commented on the issue:
https://github.com/apache/thrift/pull/1048
Travic CI seemed to fail on something not related to my change. Can someone rerun the Travis CI build?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1048: Ensuring that HTTP failures will clear the http transpor...
Posted by nsuke <gi...@git.apache.org>.
Github user nsuke commented on the issue:
https://github.com/apache/thrift/pull/1048
@thomas07vt hi thanks for the patch. The change makes sense to me.
Could you file an issue on our JIRA, if you haven't done so ?
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---