You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2022/03/11 07:28:06 UTC
[GitHub] [james-project] vttranlina opened a new pull request #913: JAMES-3724 - Enable leak detection mode is testing for test suite
vttranlina opened a new pull request #913:
URL: https://github.com/apache/james-project/pull/913
Jira: https://issues.apache.org/jira/browse/JAMES-3724
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #913: JAMES-3724 - Enable leak detection mode is testing for test suite
Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #913:
URL: https://github.com/apache/james-project/pull/913#issuecomment-1066530093
```
<h1 class="result-regression">Regression</h1><p><span style="font-weight:bold">org.apache.james.lifecycle.api.LeakAwareTest.leakDetectionShouldCloseUnclosedResources</span></p><div style="text-align:right;">Failing for the past 1 build
(Since <a href="https://ci-builds.apache.org/job/james/job/ApacheJames/job/PR-913/4/" class="model-link"><span style="width: 16px; height: 16px; " class="build-status-icon__wrapper icon-red icon-sm"><span class="build-status-icon__outer"><svg viewBox="0 0 24 24" focusable="false" class="svg-icon "><use href="https://ci-builds.apache.org/images/build-status/build-status-sprite.svg#build-status-static"></use></svg></span><svg viewBox="0 0 24 24" focusable="false" class="svg-icon icon-red icon-sm"><use href="https://ci-builds.apache.org/static/40b37e2d/images/build-status/build-status-sprite.svg#last-failed"></use></svg></span>#4</a> )
</div><div style="text-align:right;"><a href="https://ci-builds.apache.org/job/james/job/ApacheJames/job/PR-913/4/testReport/junit/org.apache.james.lifecycle.api/LeakAwareTest/leakDetectionShouldCloseUnclosedResources/history">Took 0.14 sec.</a></div><div id="description"><div></div><div class="jenkins-buttons-row jenkins-buttons-row--invert"></div></div>
<h3>Stacktrace</h3><pre>org.apache.james.lifecycle.api.Disposable$LeakAware$LeakDetectorException
at org.apache.james.lifecycle.api.LeakAwareTest.lambda$leakDetectionShouldCloseUnclosedResources$0(LeakAwareTest.java:101)
</pre><h3>Standard Output</h3><pre>03:14:48.190 [ERROR] o.a.j.l.a.Disposable$LeakAwareFinalizer - Leak detected! Resource org.apache.james.lifecycle.api.LeakAwareTest$LeakResourceSample$TestResource@ff0ab64 was not released before its referent was garbage-collected.
This resource was instanced at:
org.apache.james.lifecycle.api.LeakAwareTest$LeakResourceSample#create:55
org.apache.james.lifecycle.api.LeakAwareTest#leakDetectionShouldCloseUnclosedResources:96
org.junit.platform.commons.util.ReflectionUtils#invokeMethod:688
org.junit.jupiter.engine.execution.MethodInvocation#proceed:60
org.junit.jupiter.engine.execution.InvocationInterceptorChain$ValidatingInvocation#proceed:131
org.junit.jupiter.engine.extension.TimeoutExtension#intercept:149
org.junit.jupiter.engine.extension.TimeoutExtension#interceptTestableMethod:140
org.junit.jupiter.engine.extension.TimeoutExtension#interceptTestMethod:84
org.junit.jupiter.engine.execution.ExecutableInvoker$ReflectiveInterceptorCall#lambda$ofVoidMethod$0:115
org.junit.jupiter.engine.execution.ExecutableInvoker#lambda$invoke$0:105
org.junit.jupiter.engine.execution.InvocationInterceptorChain$InterceptedInvocation#proceed:106
org.junit.jupiter.engine.execution.InvocationInterceptorChain#proceed:64</pre>Regression
org.apache.james.lifecycle.api.LeakAwareTest.leakDetectionShouldCloseUnclosedResources
Failing for the past 1 build (Since [#4](https://ci-builds.apache.org/job/james/job/ApacheJames/job/PR-913/4/) )
[Took 0.14 sec.](https://ci-builds.apache.org/job/james/job/ApacheJames/job/PR-913/4/testReport/junit/org.apache.james.lifecycle.api/LeakAwareTest/leakDetectionShouldCloseUnclosedResources/history)
Stacktrace
org.apache.james.lifecycle.api.Disposable$LeakAware$LeakDetectorException
at org.apache.james.lifecycle.api.LeakAwareTest.lambda$leakDetectionShouldCloseUnclosedResources$0(LeakAwareTest.java:101)
Standard Output
03:14:48.190 [ERROR] o.a.j.l.a.Disposable$LeakAwareFinalizer - Leak detected! Resource org.apache.james.lifecycle.api.LeakAwareTest$LeakResourceSample$TestResource@ff0ab64 was not released before its referent was garbage-collected.
This resource was instanced at:
org.apache.james.lifecycle.api.LeakAwareTest$LeakResourceSample#create:55
org.apache.james.lifecycle.api.LeakAwareTest#leakDetectionShouldCloseUnclosedResources:96
org.junit.platform.commons.util.ReflectionUtils#invokeMethod:688
org.junit.jupiter.engine.execution.MethodInvocation#proceed:60
org.junit.jupiter.engine.execution.InvocationInterceptorChain$ValidatingInvocation#proceed:131
org.junit.jupiter.engine.extension.TimeoutExtension#intercept:149
org.junit.jupiter.engine.extension.TimeoutExtension#interceptTestableMethod:140
org.junit.jupiter.engine.extension.TimeoutExtension#interceptTestMethod:84
org.junit.jupiter.engine.execution.ExecutableInvoker$ReflectiveInterceptorCall#lambda$ofVoidMethod$0:115
org.junit.jupiter.engine.execution.ExecutableInvoker#lambda$invoke$0:105
org.junit.jupiter.engine.execution.InvocationInterceptorChain$InterceptedInvocation#proceed:106
org.junit.jupiter.engine.execution.InvocationInterceptorChain#proceed:64
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #913: JAMES-3724 - Enable leak detection mode is testing for test suite
Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #913:
URL: https://github.com/apache/james-project/pull/913#issuecomment-1066530332
https://ci-builds.apache.org/job/james/job/ApacheJames/job/PR-913/4/testReport/junit/org.apache.james.lifecycle.api/LeakAwareTest/leakDetectionShouldCloseUnclosedResources/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] vttranlina commented on a change in pull request #913: JAMES-3724 - Enable leak detection mode is testing for test suite
Posted by GitBox <gi...@apache.org>.
vttranlina commented on a change in pull request #913:
URL: https://github.com/apache/james-project/pull/913#discussion_r825547062
##########
File path: pom.xml
##########
@@ -3209,6 +3209,10 @@
<artifactId>maven-surefire-plugin</artifactId>
<version>2.22.2</version>
<configuration>
+ <systemPropertyVariables>
+ <!--https://issues.apache.org/jira/browse/JAMES-3724-->
+ <james.ligecycle.leak.detection.mode>testing</james.ligecycle.leak.detection.mode>
+ </systemPropertyVariables>
Review comment:
is it necessary? I just checked, it inherits from parent pom,
so these config properties are still available in child modules
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on a change in pull request #913: JAMES-3724 - Enable leak detection mode is testing for test suite
Posted by GitBox <gi...@apache.org>.
chibenwa commented on a change in pull request #913:
URL: https://github.com/apache/james-project/pull/913#discussion_r825541654
##########
File path: pom.xml
##########
@@ -3209,6 +3209,10 @@
<artifactId>maven-surefire-plugin</artifactId>
<version>2.22.2</version>
<configuration>
+ <systemPropertyVariables>
+ <!--https://issues.apache.org/jira/browse/JAMES-3724-->
+ <james.ligecycle.leak.detection.mode>testing</james.ligecycle.leak.detection.mode>
+ </systemPropertyVariables>
Review comment:
Please carry this configuration change in projects where we overwrite surefire configuration.
EG mailbox/cassandra
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on a change in pull request #913: JAMES-3724 - Enable leak detection mode is testing for test suite
Posted by GitBox <gi...@apache.org>.
chibenwa commented on a change in pull request #913:
URL: https://github.com/apache/james-project/pull/913#discussion_r825565105
##########
File path: pom.xml
##########
@@ -3209,6 +3209,10 @@
<artifactId>maven-surefire-plugin</artifactId>
<version>2.22.2</version>
<configuration>
+ <systemPropertyVariables>
+ <!--https://issues.apache.org/jira/browse/JAMES-3724-->
+ <james.ligecycle.leak.detection.mode>testing</james.ligecycle.leak.detection.mode>
+ </systemPropertyVariables>
Review comment:
Ok then!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] vttranlina commented on pull request #913: JAMES-3724 - Enable leak detection mode is testing for test suite
Posted by GitBox <gi...@apache.org>.
vttranlina commented on pull request #913:
URL: https://github.com/apache/james-project/pull/913#issuecomment-1064848897
WIP
This is my idea regarding the way to do it.
Create `jvm.properties` in classpath resources, declare `testing` mode. When creating the server, invoke `org.apache.james.ExtraProperties#initialize` for setting system properties.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa merged pull request #913: JAMES-3724 - Enable leak detection mode is testing for test suite
Posted by GitBox <gi...@apache.org>.
chibenwa merged pull request #913:
URL: https://github.com/apache/james-project/pull/913
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org