Proposed Path to AbstractEngine.java

["matthew c. mead" <m-...@goof.com>]

I'd like to propose this patch to AbstractEngine.java.  I've been having 
troubles under Tomcat when a client cancels a request - Tapestry does 
not end up calling cleanupAfterRequest() and the Session ends up 
invalidated().  Others have seen this problem as well.  Here are a 
couple references, followed by the proposed patch.

Thanks for your consideration.


http://marc.theaimsgroup.com/?l=tapestry-user&m=109868814105795&w=2
http://marc.theaimsgroup.com/?l=tapestry-user&m=110944496608874&w=2
http://marc.theaimsgroup.com/?l=tapestry-user&m=110945260932142&w=2

----- patch -----
--- AbstractEngine.java.original        Thu Mar 10 11:06:50 2005
+++ AbstractEngine.java Thu Mar 10 11:08:04 2005
@@ -927,12 +927,15 @@
                 if (output != null)
                     output.forceFlush();
 
-                cleanupAfterRequest(cycle);
             }
             catch (Exception ex)
             {
                 
reportException(Tapestry.getMessage("AbstractEngine.exception-during-cleanup"), 
ex);
             }
+           finally
+           {
+                cleanupAfterRequest(cycle);
+           }
 
             if (_disableCaching)
             {
----- patch -----



-matt


-- 
matthew c. mead

http://www.goof.com/