You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/07 09:50:38 UTC

[GitHub] [pulsar] andrasbeni opened a new pull request, #17515: [improve][test] Add integration test for broker interceptors

andrasbeni opened a new pull request, #17515:
URL: https://github.com/apache/pulsar/pull/17515

   Master Issue: #17132
   
   ### Motivation
   
   Increase test coverage of broker interceptor functionality.
   
   ### Modifications
   
   - Created broker interceptor `LoggingBrokerInterceptor`.
   - Created a test that configures the interceptor for the broker and verifies through the broker log that the interceptor's methods are called 
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   This change added tests and can be verified as follows:
   
    *Added integration tests for broker interceptors*
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (no)
     - The schema: (no)
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (no)
   
   ### Documentation
   
   - [x] `doc-not-needed` 
   This change only affects tests
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] andrasbeni commented on pull request #17515: [improve][test] Add integration test for broker interceptors

Posted by GitBox <gi...@apache.org>.
andrasbeni commented on PR #17515:
URL: https://github.com/apache/pulsar/pull/17515#issuecomment-1249064682

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] merlimat commented on pull request #17515: [improve][test] Add integration test for broker interceptors

Posted by GitBox <gi...@apache.org>.
merlimat commented on PR #17515:
URL: https://github.com/apache/pulsar/pull/17515#issuecomment-1251240380

   /pulsarbot rerun-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] andrasbeni closed pull request #17515: [improve][test] Add integration test for broker interceptors

Posted by GitBox <gi...@apache.org>.
andrasbeni closed pull request #17515: [improve][test] Add integration test for broker interceptors
URL: https://github.com/apache/pulsar/pull/17515


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] Technoboy- merged pull request #17515: [improve][test] Add integration test for broker interceptors

Posted by GitBox <gi...@apache.org>.
Technoboy- merged PR #17515:
URL: https://github.com/apache/pulsar/pull/17515


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] andrasbeni commented on pull request #17515: [improve][test] Add integration test for broker interceptors

Posted by GitBox <gi...@apache.org>.
andrasbeni commented on PR #17515:
URL: https://github.com/apache/pulsar/pull/17515#issuecomment-1242738777

   /pulsarbot rerun-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] andrasbeni commented on pull request #17515: [improve][test] Add integration test for broker interceptors

Posted by GitBox <gi...@apache.org>.
andrasbeni commented on PR #17515:
URL: https://github.com/apache/pulsar/pull/17515#issuecomment-1249226772

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] andrasbeni commented on pull request #17515: [improve][test] Add integration test for broker interceptors

Posted by GitBox <gi...@apache.org>.
andrasbeni commented on PR #17515:
URL: https://github.com/apache/pulsar/pull/17515#issuecomment-1252336392

   /pulsarbot rerun-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] andrasbeni commented on pull request #17515: [improve][test] Add integration test for broker interceptors

Posted by GitBox <gi...@apache.org>.
andrasbeni commented on PR #17515:
URL: https://github.com/apache/pulsar/pull/17515#issuecomment-1244121267

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] andrasbeni closed pull request #17515: [improve][test] Add integration test for broker interceptors

Posted by GitBox <gi...@apache.org>.
andrasbeni closed pull request #17515: [improve][test] Add integration test for broker interceptors
URL: https://github.com/apache/pulsar/pull/17515


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org